This actually makes this fallback implementation unsuitable for
early intialized random values like stack guards.

Signed-off-by: Martin Storsjö <[email protected]>
---
 mingw-w64-libraries/winstorecompat/src/Crypto.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/mingw-w64-libraries/winstorecompat/src/Crypto.c 
b/mingw-w64-libraries/winstorecompat/src/Crypto.c
index 349184861..332dc613f 100644
--- a/mingw-w64-libraries/winstorecompat/src/Crypto.c
+++ b/mingw-w64-libraries/winstorecompat/src/Crypto.c
@@ -59,6 +59,9 @@ BOOL WINAPI CryptAcquireContextW(HCRYPTPROV *phProv, LPCTSTR 
pszContainer, LPCTS
         return FALSE;
     }
 
+    // Note; this fails if run early in the process init (e.g. while running
+    // DLL constructors); it succeeds if called later on, when the runtime
+    // has started up properly.
     __x_ABI_CWindows_CSecurity_CCryptography_CICryptographicBufferStatics 
*cryptoStatics = NULL;
     hr = RoGetActivationFactory(hClassName, 
&IID___x_ABI_CWindows_CSecurity_CCryptography_CICryptographicBufferStatics, 
(void**)&cryptoStatics);
     WindowsDeleteString(hClassName);
-- 
2.25.1



_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to