On Fri, 30 Sep 2022, LIU Hao wrote:
在 2022/9/30 05:25, Martin Storsjö 写道:
+
+#ifdef _X86_
+BOOLEAN (WINAPI *__MINGW_IMP_SYMBOL(SystemFunction036))(PVOID
RandomBuffer, ULONG RandomBufferLength)
__asm__("__imp__SystemFunction036@8") = SystemFunction036;
+#else
+BOOLEAN (WINAPI *__MINGW_IMP_SYMBOL(SystemFunction036))(PVOID
RandomBuffer, ULONG RandomBufferLength) __asm__("__imp__SystemFunction036")
= SystemFunction036;
+#endif
Is the asm name for non-x86 correct? I would expect it to be
`__imp_SystemFunction036`.
The others look good to me.
I realize I overlooked this part of your reply before; if you're ok with
the rest of the patches, I guess it's time to land them.
Do you (or Alvin) have an opinion on the two RFC patches - adding ssp
functions for the printf family and gets(), which aren't used yet, and
complicating the stack guard initialization, trying to use other APIs than
plain rand_s (which would still be referenced as fallback) - should we add
them or leave them out for now?
// Martin
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
