Hi! Right, the Windows SDK defines FLS_MAXIMUM_AVAILABLE unconditionally, let's do the same here.
Thank you! Luca ________________________________ Da: LIU Hao <[email protected]> Inviato: lunedì, giugno 5, 2023 4:01:51 PM A: [email protected] <[email protected]>; Luca Bacci <[email protected]> Oggetto: Re: [Mingw-w64-public] [PATCH] Define FLS_MAXIMUM_AVAILABLE as 4080 for WIN10_19H1 在 2023-06-05 16:54, Luca Bacci 写道: > Windows 10 19H1 raised the number of available FLS slots > from 128 to 4080 [1] and the Windows SDK was updated > accordingly Let's think about this: This patch adds another imaginary macro `_WIN32_WINNT_WIN10_19H1` that is referenced nowhere in Windows SDK. I'd prefer the previous patch (without any `#if`) for these reasons: 1) There isn't such a check in public Windows SDK headers. 2) 10.0.18362.0 is the earliest SDK that is available in Visual Studio 2022 and it is exactly 19H1. 3) If the user does not define `NTDDI_VERSION` but defines `_WIN32_WINNT` to `0x0A00` i.e. Windows 10, then `NTDDI_VERSION` is defined to latest, which means Windows 10 targets should probably receive all latest stuff, including the FLS extension. 4) Ironically, Windows 11 is still identified as version 10 for its `NTDDI_*` macro. 5) And that's what was done in d78ef3552df8cdbfd1a275296921787975573d54. -- Best regards, LIU Hao _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
