This is good point against using "continue-on-error: true", thanks for pointing out.
I wonder which tests cause testsuite to hang, can it be tests/pthread_misc/strss1.c? I guess we could skip it (return 77) for now on arm? For tests that actually fail on arm, we could mark them as expected failures just like other failing tests. Obviously, these failures need to be further investigated. It would be much easier to debug these issues if I had an arm system, but unfortunately, I don't. - Kirill Makurin ________________________________ From: Martin Storsj? <[email protected]> Sent: Sunday, September 28, 2025 4:47 PM To: mingw-w64-public <[email protected]> Subject: Re: [Mingw-w64-public] [V2] winpthreads: integrate tests from tests_pthread directory with Automake On Sun, 14 Sep 2025, Kirill Makurin wrote: > I pushed this patch series to by GitHub fork and noticed that all > testcases-clang failed on aarch64[1]. The reason was > pthread_misc/context1.c which was not prepared to handle arm platforms. > I am not familiar with arm[64] and CONTEXT structure used in this test, > so I simply added preprocessor conditions to skip this test for arm > (patch 5). It still seems like they hang in this configuration. > I took a quick look at definition of CONTEXT structure and wonder if > `Pc` member is the proper one for this test? I'll have to look closer at this test when I have more time. > Patch 12 adds GitHub CI integration. I added a new step "Build and test > winpthreads" to testcases-{gcc,clang} jobs. I also marked "Build > mingw-w64-crt and run testcases" step with "continue-on-error: true", I > think it would nice to run winpthreads tests even if crt build/tests > failed. Feel free to remove it if you don't like it. Yeah I disagree about that part. If the crt build/tests fail, we have a fatal issue there already - we shouldn't be in that state. And if we are in that state, running/investigating the winpthreads test is a smaller concern anyway. Then as a bigger concern - "continue-on-error: true" means that even if you'd have a test failure in mingw-w64-crt tests, it would still mark the overall job as a success - so essentially it ignores all failures here, not just tries to run the winpthreads tests as well. So we really shouldn't include that flag here. // Martin _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
