On Thu, 16 Oct 2025, LIU Hao wrote:
在 2025-10-16 18:19, Martin Storsjö 写道:
On Wed, 15 Oct 2025, Peter0x44 via Mingw-w64-public wrote:
However, I noticed it got applied with an author of "Peter Damianov via
Mingw-w64-public <mingw-w64- [email protected]>"
I would prefer if this didn't happen again.
This is quite unfortunate - and catching it requires a bit of extra
vigilance when applying the patches (and may require looking up what the
real email address should be - although if it's part of a preexisting
Signed-off-by, it's clearer).
There's one way to avoid the issue; by passing the "--force-in-body-from"
option to git format-patch or send-email, it adds an extra explicit "From:"
field in the body of the message (just like it does if you're sending a
patch from a different author than yourself), so "git am" gets the right
form of the author from there when applying it.
Apologies. I fixed it once in 8612006d7f5376cdefa7c887db6d3dfb48d285be, but
forgot to look at it in later patches.
This is yet another reason why I recommend patches be sent as attachments.
Patches as attachments is indeed a more robust transport, but it also
makes it harder to do an inline code review in the mail app (depending on
what mail app one uses of course).
// Martin
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
