On 2025-10-15 15:53, LIU Hao wrote:
在 2025-10-14 11:21, Peter Damianov via Mingw-w64-public 写道:
Implement C23 binary format specifiers:
- Add %b and %B format support
- Support # flag for 0b/0B prefixes
- Add 128-bit binary conversion __bigint_to_stringb
- Include scanf parsing support
- Support modifiers like field width, padding, etc

Signed-off-by: Peter Damianov <[email protected]>
---
mingw-w64-crt/stdio/mingw_pformat.c | 39 +++++++++++++++++++++++++----
  mingw-w64-crt/stdio/mingw_sformat.c |  4 +++
  2 files changed, 38 insertions(+), 5 deletions(-)


Thanks for the patch. This passes llvm and libcxx tests for now, so pushed to master.

There is actually a minor issue in both `__bigint_to_stringb()` and `__bigint_to_stringo()`: The condition `(pos < bufflen - 1)` seems always true, because `pos` starts from `bufflen - 2` and goes backwards, and if it drops to zero in the loop, it breaks the loop. That can be updated in a separate patch.

Thanks for applying it.

However, I noticed it got applied with an author of "Peter Damianov via Mingw-w64-public <[email protected]>"
I would prefer if this didn't happen again.

Regards,


_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to