Hi John, On 27 Dec 2010, at 12:58, John Deal <bassd...@yahoo.com> wrote:
> Hello Max, > > I did as instructed. I issued a proposed merger as detailed in the > developer's instructions. I hope that was the correct thing to do. Well done! It looks like you've got the hang of Bazaar. :) I have taken a look at your branch. Your fix is short and sweet, and your revision comment is informative: that is exactly what we would be looking for in this sort of bug-fixing scenario. There is just a couple of things I would like to point out: - It looks like you are not logged in to your Launchpad account with Bazaar. You appear to have set 'bzr whoami [etc.]' correctly (because your name and email show up in the revision record on Launchpad), but not 'bzr launchpad-login bassdeal' (which would link your revision to your Launchpad account). - Your commit, revision 221, fixes the bug you reported (number 694335 on Launchpad). It is best to link your revision which fixes the bug to the associated bug report on Launchpad (using the technique explained here: http://miragroupware.org/wiki/doku.php/development/bazaartechniques#fixing-a-bug) or, instead, your could link your branch to the bug using the 'Link to a bug report' tool on your Launchpad branch: https://code.launchpad.net/~mira-dev/mira/workplace-desc Also, please note that your fix now conflicts with Alan's fix for this, which has yet to be merged into trunk: http://bazaar.launchpad.net/%7Emira-dev/mira/login-system/revision/243 You are correct to have proposed to merge your branch into trunk. We just need to discuss with Alan whether to complete the merge of your branch, or wait for his branch to be merged before merging yours, or to treat yours as an exercise and abandon the branch. In any case, excellent work! :) > How should I determine my next task? Please take a look at our Outstanding Targets for 0.2 and take your pick: http://miragroupware.org/wiki/doku.php/development/roadmap/outstanding Whichever interests you most! Regards, Max Bossino Project Manager http://miragroupware.org ------------------------------------------------------------------------------ Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ Mira-development mailing list Mira-development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mira-development
