Hello Max, OK I see where I screwed up. Oh well :-(. Anyway it most likely is better to drop my branch and use Alan's fix since his fix is integrated with other functionality. Mine also has some coding standards issues (no "_" between variable name words).
I am a bit confused about how bugs are reported and assigned. For example, I can't find any mention of the Workplace Summary space problem in the bug list in Launchpad so I assumed it was unreported (implying not known although that was not the case). It is mentioned in Alan's branch information. The Launchpad bug display does not have an "assigned" field. How do you know if a bug is being worked on? As far as next tasks, I am very interested in the database work which does not seem to be implemented yet (ex. soci library). There seems to be a disconnect between the text documentation in the Wiki and the "Mira Groupware Infrastructure - Layers Diagram" graphic. The graphic shows the Database layer and Directory layer in parallel while the text implies the Directory layer consists of separate plain text, database, and LDAP components. The text also seems to indicate the Storage layer contains a database component. Anyway I think this is interesting. I would not mind working on doxygen documentation (I see the comments are there but I have not seen any resulting documentation) or bugs. Thanks, John --- On Mon, 12/27/10, Max Bossino <m...@miragroupware.org> wrote: > From: Max Bossino <m...@miragroupware.org> > Subject: Re: [Mira-development] Mira-Bazaar question > To: "Mira Development Mailing List" <mira-development@lists.sourceforge.net> > Date: Monday, December 27, 2010, 11:35 AM > Hi John, > > On 27 Dec 2010, at 12:58, John Deal <bassd...@yahoo.com> > wrote: > > > Hello Max, > > > > I did as instructed. I issued a proposed merger > as detailed in the developer's instructions. I hope > that was the correct thing to do. > > Well done! It looks like you've got the hang of Bazaar. :) > > I have taken a look at your branch. Your fix is short and > sweet, and your revision comment is informative: that is > exactly what we would be looking for in this sort of > bug-fixing scenario. There is just a couple of things I > would like to point out: > > - It looks like you are not logged in to your Launchpad > account with Bazaar. You appear to have set 'bzr whoami > [etc.]' correctly (because your name and email show up in > the revision record on Launchpad), but not 'bzr > launchpad-login bassdeal' (which would link your revision to > your Launchpad account). > - Your commit, revision 221, fixes the bug you reported > (number 694335 on Launchpad). It is best to link your > revision which fixes the bug to the associated bug report on > Launchpad (using the technique explained here: > http://miragroupware.org/wiki/doku.php/development/bazaartechniques#fixing-a-bug) > or, instead, your could link your branch to the bug using > the 'Link to a bug report' tool on your Launchpad branch: > https://code.launchpad.net/~mira-dev/mira/workplace-desc > > Also, please note that your fix now conflicts with Alan's > fix for this, which has yet to be merged into trunk: > http://bazaar.launchpad.net/%7Emira-dev/mira/login-system/revision/243 > You are correct to have proposed to merge your branch into > trunk. We just need to discuss with Alan whether to complete > the merge of your branch, or wait for his branch to be > merged before merging yours, or to treat yours as an > exercise and abandon the branch. In any case, excellent > work! :) > > > How should I determine my next task? > > Please take a look at our Outstanding Targets for 0.2 and > take your pick: > http://miragroupware.org/wiki/doku.php/development/roadmap/outstanding > Whichever interests you most! > > Regards, > > Max Bossino > Project Manager > http://miragroupware.org > ------------------------------------------------------------------------------ > Learn how Oracle Real Application Clusters (RAC) One Node > allows customers > to consolidate database storage, standardize their database > environment, and, > should the need arise, upgrade to a full multi-node Oracle > RAC database > without downtime or disruption > http://p.sf.net/sfu/oracle-sfdevnl > _______________________________________________ > Mira-development mailing list > Mira-development@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mira-development > ------------------------------------------------------------------------------ Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ Mira-development mailing list Mira-development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mira-development
