Thorsten Glaser <[email protected]> wrote:
|Steffen Daode Nurpmeso dixit:
|
|>maybe this test would be worth adding to check.t.
|>I think i do assume the correct behaviour.
|
|Indeed. A bit late, but I applied the testsuite part
|(not the dot.mkshrc part because I don’t think that
|should be default) with only very minor changes
|(basically, put it next to the other trap-* tests and
|rename it to something similar).
|
|Then I discovered my mksh on herc is too old and that
|your test broke between R41 and R41b. I tried to find
|the hunk that introduced that change and was a bit
|surprised at which one it was, and that it also breaks
|pressing ^C while the EXIT trap is defined… maybe that
|was one of your problems in the thread starting at
|http://thread.gmane.org/gmane.os.miros.mksh/91 too; if
|so please say so and I can finally put that thing out
|of my TOD^WINBOX.
It's all fine now! Great!
And looking forward for a bright, resurrected R49!
|Finally, I decided on the most correct-ish fix I could
|do without breaking other things in the process.
|
|It’s not in mksh R47 but in CVS HEAD, so I’d love if
|you can give that a try – especially if it indeed closes
|your other issues too.
|
|>Anyway, have a good time!
|
|Thanks, you too!
..Thorsten.
|By the way, if you have any other outstanding issues,
|please prod me again. Other than
|• EXIT trap and syntax errors
|• ^C exits shell (maybe the same problem?)
|• long job names
Ja-ah (but
jobs.c: long job names, please
---
jobs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/jobs.c b/jobs.c
index b5ec5f5..5d7dbb0 100644
--- a/jobs.c
+++ b/jobs.c
@@ -45,7 +45,7 @@ struct proc {
int state;
int status; /* wait status */
/* process command string from vistree */
- char command[64 - (ALLOC_SIZE + sizeof(Proc *) + sizeof(pid_t) +
+ char command[2048 - (ALLOC_SIZE + sizeof(Proc *) + sizeof(pid_t) +
2 * sizeof(int))];
};
is really a good thing to have!)
|I’ve not got any of yours on my radar atm… did I forget some?
Well, it's only minor convenience shit for me, like the „expansion
in the middle of a word“ and „when traversing history $COLUMNS
should be used fully, not `WIDTH % $COLUMNS', when displaying
linee with `WIDTH > $COLUMNS'”. Shitty stuff like that...
Ciao!
|bye,
|//mirabilos
--steffen
