On Wed, Nov 22, 2017 at 12:42:52AM +0000, Thorsten Glaser wrote:
> Hi,
> 
> what’s -D_DEFAULT_SOURCE for?

Morning Thorsten,

AFAICS from /usr/include/features.h

   _DEFAULT_SOURCE      The default set of features (taking precedence over
                        __STRICT_ANSI__).

as well as from `info libc'

 -- Macro: _DEFAULT_SOURCE
     If you define this macro, most features are included apart from
     X/Open, LFS and GNU extensions: the effect is to enable features
     from the 2008 edition of POSIX, as well as certain BSD and SVID
     features without a separate feature test macro to control them.
     Defining this macro, on its own and without using compiler options
     such as `-ansi' or `-std=c99', has the same effect as not defining
     any feature test macros; defining it together with other feature
     test macros, or when options such as `-ansi' are used, enables
     those features even when the other options would otherwise cause
     them to be disabled.

> Also, do *NOT* patch checking for sys_siglist and sys_errlist
> out of Build.sh; instead, use the overrides system, if you
> must. (They are more reliable, in general.)
> 
> To do that, just
>       export HAVE_SYS_ERRLIST=0
>       export HAVE__SYS_ERRLIST=0
>       export HAVE_SYS_SIGLIST=0
>       export HAVE__SYS_SIGLIST=0
> before running Build.sh.

As long as mksh does not use hard coded lists I'll do this.

> 
> Avoiding LTO is wise, nowadays, yes…
> 
> What’s -ftree-loop-linear for? If it makes sense, I can
> include it in the list of CFLAGS to check for.

This should help to do loop nest optimizations, at least
gcc manual page does show this

       -ftree-loop-linear
       -floop-interchange
       -floop-strip-mine
       -floop-block
       -floop-unroll-and-jam
           Perform loop nest optimizations.  Same as -floop-nest-optimize.  To
           use this code transformation, GCC has to be configured with
           --with-isl to enable the Graphite loop transformation
           infrastructure.

> Interesting approach in using GNU screen, not script(1),
> to provide a tty. But if it works… sure.

Yep, this I had done a few years back for building clisp and
also for original ksh to have a pty/tty pair and as I'm familiar
with screen I decided to use this.

> You do not seem to provide a way for a user to avoid the
> vendor-provided /etc/mkshrc file. In Debian and others,
> I put something into /etc/skel/.mkshrc which sources it
> by default, but which the user can override; furthermore,
> you load /etc/mkshrc also if ENV is not unset. Users may
> not like this.

Hmmm ... good point

> 
> Feel free to look at home:mirabile/mksh for a reference
> package.
> 
> Nevertheless, thanks for taking care of mksh in SuSE!
> //mirabilos

Werner

-- 
  "Having a smoking section in a restaurant is like having
          a peeing section in a swimming pool." -- Edward Burr

Attachment: signature.asc
Description: PGP signature

Reply via email to