On Mon, Jun 16, 2025 at 11:13:07AM -0000, Stuart Henderson wrote: > On 2025-06-16, Claus Assmann <[email protected]> wrote: > > While trying to find a way to get fw_update to work during autoinstall > > without an internet connection, I noticed the use of the word > > "setup" - maybe someone can take a look and decide whether the > > following patch is ok/worth applying? > > > > --- install.sub.orig Mon Jun 16 06:11:51 2025 > > +++ install.sub Mon Jun 16 06:13:36 2025 > > @@ -2277,7 +2277,7 @@ > > > > # Gather information for setting up the user later in do_install(). > > user_setup() { > > - local _q="Setup a user? (enter a lower-case loginname, or 'no')" > > + local _q="Set up a user? (enter a lower-case loginname, or 'no')" > > this change will break autoinstall scripts.
Couldn't we just leave this instance as 'Setup', and change the others to 'set up'? At least for the time being? > > @@ -2319,7 +2319,7 @@ > > } > > > > # Ask user whether or not to allow logins to root in case sshd(8) is > > enabled. > > -# If no user is setup, show a hint to enable root logins, but warn about > > risks > > +# If no user is set up, show a hint to enable root logins, but warn about > > risks This is just a source code comment, fixing spelling here shouldn't cause any issues. > > - echo "Since no user was setup, root logins via sshd(8) might be > > useful." > > + echo "Since no user was set up, root logins via sshd(8) might > > be useful." Does anything anywhere actually pass this output?
