On Wed, Jun 18, 2025 at 10:23:01AM +0100, Stuart Henderson wrote: > On 2025/06/18 03:41, Crystal Kolipe wrote: > > On Mon, Jun 16, 2025 at 11:13:07AM -0000, Stuart Henderson wrote: > > > On 2025-06-16, Claus Assmann <[email protected]> wrote: > > > > While trying to find a way to get fw_update to work during autoinstall > > > > without an internet connection, I noticed the use of the word > > > > "setup" - maybe someone can take a look and decide whether the > > > > following patch is ok/worth applying? > > > > > > > > --- install.sub.orig Mon Jun 16 06:11:51 2025 > > > > +++ install.sub Mon Jun 16 06:13:36 2025 > > > > @@ -2277,7 +2277,7 @@ > > > > > > > > # Gather information for setting up the user later in do_install(). > > > > user_setup() { > > > > - local _q="Setup a user? (enter a lower-case loginname, or 'no')" > > > > + local _q="Set up a user? (enter a lower-case loginname, or > > > > 'no')" > > > > > > this change will break autoinstall scripts. > > > > Couldn't we just leave this instance as 'Setup', and change the others to > > 'set up'? > > > > At least for the time being? > > Honestly "set up" doesn't seem much (if any) better than "setup" to me, > neither of these really seem like a great choice for what's being done > here.
Well 'Setup' is bad English, because 'setup' is a noun. 'Set up' is the verb form. That, as I understood it, was the motive for the OP's original patch. But agreed that neither version is a good description of what the installer is doing.
