Hey Otto,
Thanks for your message.
From [email protected] Fri Jun 5 10:56:27 2009
One other thing you need to consider: does the code in
question need to be diffed with another repository, upstream
or other BSD, for example. In the case of nvi it is.
Whitescpae and formatting diffs make it hard to track and
merge changes from other places.
Okay, I went over the CVS logs and did note some patches pulled in
from ... at least 1.81.5 it seems. I had thought that no patches
were being pulled in since 1.79, but I guess I was wrong.
So...that means no whitespace and formatting changes, but should I
stick with formatting styles used in the surrounding code then, for
consistency? My guess is yes. If I alter a file enough that it could
benefit from reformatting, should I leave it the old style to match
with the surrounding files as well? I'm a bit unclear on where that
line is drawn. (From what it looks like, I'll be editing maybe one
or two files significantly, but probably not more than four files
or so, and I don't know whether that warrants using a newer style
in those files or sticking with the old stuff.)
--
Aaron W. Hsu <[email protected]> | <http://www.sacrideo.us>
"Government is the great fiction, through which everybody endeavors to
live at the expense of everybody else." -- Frederic Bastiat
+++++++++++++++ ((lambda (x) (x x)) (lambda (x) (x x))) ++++++++++++++
