On Mon, Jun 8, 2009 at 8:16 PM, Aaron W. Hsu<[email protected]> wrote: > Hey Otto, > > Thanks for your message. > > B B B B From [email protected] Fri Jun B 5 10:56:27 2009 > > B B B B One other thing you need to consider: does the code in > B B B B question need to be diffed with another repository, upstream > B B B B or other BSD, for example. In the case of nvi it is. > B B B B Whitescpae and formatting diffs make it hard to track and > B B B B merge changes from other places. > > Okay, I went over the CVS logs and did note some patches pulled in > from ... at least 1.81.5 it seems. I had thought that no patches > were being pulled in since 1.79, but I guess I was wrong. > > So...that means no whitespace and formatting changes, but should I > stick with formatting styles used in the surrounding code then, for > consistency? My guess is yes. If I alter a file enough that it could > benefit from reformatting, should I leave it the old style to match > with the surrounding files as well? I'm a bit unclear on where that > line is drawn. (From what it looks like, I'll be editing maybe one > or two files significantly, but probably not more than four files > or so, and I don't know whether that warrants using a newer style > in those files or sticking with the old stuff.)
I think it might be best for you to see if you can have your changes incorporated into upstream (nvi maintainers). That way, your changes, if extensive, would be much easily accepted into internal repository. That said I'm not sure how actively is nvi being developed and/or maintained. Seems like mid Nov 2007 was the last time it was touched/updated [1]. --patrick [1] http://www.bostic.com/vi/ http://www.kotnet.org/~skimo/nvi/
