Hello, It'll be reworked, but the quick fix should be ok, what I want to rework is how the fix was integrated so that the difference between master and portable is reduced.
Gilles On Mon, Jan 06, 2014 at 10:18:16PM +0600, Denis Fateyev wrote: > Hello Gilles, > > Is that issue settled out? I mean, do you have any plans to re-work the > code related to SNI, or that quick fix is finally decided to be the > permanent solution? > > Thanks, > > --- > wbr, Denis. > > On Sun, Dec 15, 2013 at 1:57 AM, Gilles Chehade <gil...@poolp.org> wrote: > > > On Sat, Dec 14, 2013 at 01:21:17AM +0600, Denis Fateyev wrote: > > > > > > ------------------ > > > gcc -DHAVE_CONFIG_H -I. -I../.. -I../../smtpd -I../../openbsd-compat > > > -I../../contrib/lib/libc/asr -I. -DSMTPD_CONFDIR=\"/etc/opensmtpd\" > > > -DPATH_CHROOT=\"/var/empty/smtpd\" -DPATH_SMTPCTL=\"/usr/sbin/smtpctl\" > > > -DPATH_MAILLOCAL=\"/usr/libexec/opensmtpd/mail.local\" > > > -DPATH_FILTERS=\"/usr/libexec/opensmtpd\" > > > -DPATH_TABLES=\"/usr/libexec/opensmtpd\" -DHAVE_CONFIG_H -DIO_SSL > > > -DASR_OPT_THREADSAFE=0 -DCA_FILE=\"/etc/pki/tls/cert.pem\" -g > > > -I/usr/include/libdb4 -fPIC -DPIC -Wall -Wpointer-arith -Wuninitialized > > > -Wsign-compare -Wformat-security -Wno-pointer-sign -fno-strict-aliasing > > > -fno-builtin-memset -std=gnu99 -D_GNU_SOURCE -MT smtpd-smtpd.o -MD -MP > > -MF > > > .deps/smtpd-smtpd.Tpo -c -o smtpd-smtpd.o `test -f '../../smtpd/smtpd.c' > > || > > > echo './'`../../smtpd/smtpd.c > > > cc1: warning: -Wuninitialized is not supported without -O > > > ../../smtpd/smtp_session.c: In function 'smtp_sni_callback': > > > ../../smtpd/smtp_session.c:1753: warning: implicit declaration of > > function > > > 'SSL_get_servername' > > > ../../smtpd/smtp_session.c:1753: error: 'TLSEXT_NAMETYPE_host_name' > > > undeclared (first use in this function) > > > ../../smtpd/smtp_session.c:1753: error: (Each undeclared identifier is > > > reported only once > > > ../../smtpd/smtp_session.c:1753: error: for each function it appears in.) > > > ../../smtpd/smtp_session.c:1753: warning: assignment makes pointer from > > > integer without a cast > > > ../../smtpd/smtp_session.c:1755: error: 'SSL_TLSEXT_ERR_NOACK' undeclared > > > (first use in this function) > > > ../../smtpd/smtp_session.c:1765: warning: implicit declaration of > > function > > > 'SSL_set_SSL_CTX' > > > ../../smtpd/smtp_session.c:1766: error: 'SSL_TLSEXT_ERR_OK' undeclared > > > (first use in this function) > > > ../../smtpd/smtp_session.c:1767: warning: control reaches end of non-void > > > function > > > make[3]: *** [smtpd-smtp_session.o] Error 1 > > > make[3]: *** Waiting for unfinished jobs.... > > > ../../smtpd/smtpd.c: In function 'parent_auth_pam': > > > ../../smtpd/smtpd.c:1526: warning: initialization from incompatible > > pointer > > > type > > > ../../smtpd/smtpd.c:1526: warning: initialization discards qualifiers > > from > > > pointer target type > > > mv -f .deps/smtpd-smtpd.Tpo .deps/smtpd-smtpd.Po > > > make[3]: Leaving directory > > > `/home/mock/rpmbuild/BUILD/opensmtpd-201312131550p1/mk/smtpd' > > > make[2]: *** [all-recursive] Error 1 > > > make[2]: Leaving directory > > > `/home/mock/rpmbuild/BUILD/opensmtpd-201312131550p1/mk' > > > make[1]: *** [all-recursive] Error 1 > > > make[1]: Leaving directory > > > `/home/mock/rpmbuild/BUILD/opensmtpd-201312131550p1' > > > make: *** [all] Error 2 > > > ------------------ > > > > > > Perhaps related to recent SNI changes. With earlier snapshot > > (201312081717) > > > and 5.4.1 release everything was OK. > > > > > > > Latest snapshot has a quick fix, I'll improve this week since I intend > > to continue work in that area > > > > -- > > Gilles Chehade > > > > https://www.poolp.org @poolpOrg > > -- Gilles Chehade https://www.poolp.org @poolpOrg -- You received this mail because you are subscribed to misc@opensmtpd.org To unsubscribe, send a mail to: misc+unsubscr...@opensmtpd.org
