Hello Michael, I totally forgot to install the hook on my laptop! Sorry for that! Also, I will test more thoroughly on the MITK master - not just when GitHub reports merge problems.
All best, Rostislav > On 29 Aug 2014, at 06:47, "Müller, Michael" > <[email protected]> wrote: > > Hi Rotislav, > > your pull request 75 (QSortFilterProxyModel) was integrated. Wasn't that easy > though since there were some changes in the DataManagerView Class. > Furthermore there were trailinig whitespaces in your commits which were > rejected by our server side hook. As you are one of our "best" contributors > ;) please consider using our local hook (http://mitk.org/MitkGit) which > enforces some of our coding guidelines and makes integration much easier. > > Thanks, Bye > Michael > > -----Ursprüngliche Nachricht----- > Von: Rostislav Khlebnikov [mailto:[email protected]] > Gesendet: Sonntag, 17. August 2014 17:36 > An: mitk-users > Betreff: Re: [mitk-users] List of potential contributions > > > Hi, > > I have added three pull requests. > > QSortFilterProxyModel in data manager: > https://github.com/MITK/MITK/pull/75 > http://bugs.mitk.org/show_bug.cgi?id=18025 > > CGAL-based surface cutter: > https://github.com/MITK/MITK/pull/73 > http://bugs.mitk.org/show_bug.cgi?id=13948 > > Steps in progress bar for base data loading: > https://github.com/MITK/MITK/pull/74 > http://bugs.mitk.org/show_bug.cgi?id=18023 > > Regarding planar figures: > The code for undo/redo is finished. So I guess I will make a pull request. If > you don't mind - I will clump this change with additional features for > ellipses and circles. > There was not bug report for the additional features. Some features of > ellipses were there (the two radii), I just added some more. > Also I have a small question: what was is additional line from center of the > ellipse for? Is it for measuring radius in particular direction? It was quite > useless for my purposes, so I cut out this functionality, but I can restore > it if anyone needs it when preparing pull request. > > All best, > Rostislav. > > > > > >> On 13/08/2014 15:16, Sascha Zelzer wrote: >> Hi Rostislav, >> >> thanks for all your work and willingness to contribute! Please find my >> comments inline below. >> >>> On 08/07/2014 05:33 PM, Rostislav Khlebnikov wrote: >>> Dear all, >>> >>> now that I have implemented several changes to MITK that I needed I >>> would like to know what the community thinks about those changes and >>> whether they want them to be integrated to main MITK - I will prepare >>> the pull requests in case people are interested. Some are really tiny >>> :) >>> >>> - (Pull request preparation in progress) Data manager using >>> QSortFilterProxyModel for filtering the data nodes - this fixes some >>> problems with layers not being assigned correctly for hidden nodes >>> and adds more flexibility by avoiding the hard-coding of predicates >>> used to determine if the node needs to be shown. This also allows >>> adding the notion of "hidden nodes" which are hidden from the data >>> manager, but unlike "helper object" nodes are saved to the MITK scene file. >> >> Judging from the discussion it looks like a proxy model would make >> absolute sense and simplify a couple of things. So yes, please file a >> pull request. It will then also be easier for us to judge the >> implications and benefits. >> >>> >>> - (Pull request preparation in progress) CGAL-based mitk::Surface >>> slicing for 2D rendering - improves the rendering performance >>> significantly. >> >> This sounds interesting, I will send you another mail for the specific >> mitk-users thread. >> >>> - Planar figure features for mitk::PlanarEllipse (2 radii, >>> circumference and area) and mitk::PlanarCircle (circumference) >> >> Could you point me to a mitk-users discussion or a bug report for >> this? It sounds worth integrating, but I would need more context >> information. >>> >>> - Undo/redo on planar figures. This also includes refactoring of the >>> planar figure code where the number of control points wasn't equal to >>> the length of the list of control points. This was needed for figure >>> placement to specify the number of points that had to be created on >>> the first click. This caused a lot of confusion for me and seems very >>> unnatural to me. I added a GetPlacementNumberOfControlPoints() method >>> to resolve this issue. http://bugs.mitk.org/show_bug.cgi?id=13974. >> >> Again, this sound like a useful addition. If you need more feedback, >> please provide the background information in the cited bug. We would >> love to have the feature, but right now I cannot judge possible >> implications and side-effects. If your code is already finished, we >> are happy to review it. >> >>> - Property to instruct mitkImageVTKMapper2D to render gradient >>> magnitude instead of an actual image without preparing full 3D >>> gradient magnitude image. Uses vtkImageGradientMagnitude filter and >>> vtkImageHistogramStatistics to set the gradient magnitude to color >>> mapping. >> >> While this also sounds like a useful addition, we are currently >> working on restructuring the mitkImageVTKMapper2D class to make it >> more modular and customizable. The first steps are being worked on in >> bug http://bugs.mitk.org/show_bug.cgi?id=18013. So I would suggest to >> post-pone this contribution but to add your requirements / ideas to >> that bug report. >> >>> - Add steps to progress bar for loading of base data objects when >>> loading MITK scene file - makes the loading process feel more >>> responsive. >> >> Sure! >> >> >> Thanks again, >> >> Sascha >> >> >> >> >>> >>> So as you can see, I will prepare the pull requests for the first two >>> - let me know if you are interested in the rest. >>> >>> Rostislav. >>> >>> >>> >>> --------------------------------------------------------------------- >>> --------- >>> >>> Infragistics Professional >>> Build stunning WinForms apps today! >>> Reboot your WinForms applications with our WinForms controls. >>> Build a bridge from your legacy apps to the future. >>> http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg >>> .clktrk >>> >>> _______________________________________________ >>> mitk-users mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/mitk-users > > > > > ------------------------------------------------------------------------------ > _______________________________________________ > mitk-users mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/mitk-users ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ mitk-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mitk-users
