On Mon, Dec 15, 2008 at 5:38 AM, Garth Dahlstrom <[email protected]> wrote: > We are going to commit this... Obviously, I'm not a cmake expert, so I > don't know which of the two patches we should use as the base.. > > If it's Claudio's do we need a new cut of the patch (has it changed?)... > If its Helio's it probably hasn't changed (you said you had it for a > while)... Ideally we want to get the best bits of both. I was supposed to work on merging the two this weekend but my girlfriend needed help with making lasagna... (I'm not kidding, one day making lasagna + one day eating them with friends can be disastrous for coding ;) )
The second version of my patch is starting to look more interesting in my opinion as it contains complete osx cpack integration. However the main difference is in how options are handled. Helio's version will compile more easily as it will search for all available headers and enable features based on what it finds. My version is a bit pickier in that if, for example, WITH_LADSPA is enabled, it will look for ladspa.h and will fail if it doesn't find it. Both methods will do just fine. From my point of view, hard dependencies make it more difficult to create strange and difficult to support combinations, which will make life easier for distros and ourselves. However soft dependencies make it easier for potential new developers to compile mixxx as they will get something that builds in any case. I'd like to hear what your (ie mixxx developers) choice on this matter is, do you prefer softer or harder dependency tracking? soft dependencies-> we start from helio's patch and integrate my stuff hard dependencies-> we start from my patch and integrate helio's stuff PS: I got a used flybook and installed ubuntu on it so I'll be able to work on .deb packaging, more on this later. PPS: Can I work on this on svn? I have a sf account with attached ssh public cert. If you need guarantees, I have been on the kde commiters list for a while (even though I understand svn access to kde is rather easier to obtain ;) ) -- Claudio Bantaloukas http://www.rdfm.org/ammuzzu/ ------------------------------------------------------------------------------ SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. The future of the web can't happen without you. Join us at MIX09 to help pave the way to the Next Web now. Learn more and register at http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/ _______________________________________________ Mixxx-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mixxx-devel
