On Fri, 2009-02-13 at 21:48 -0500, Nick Guenther wrote: > In MidiMapping::ComputeValue() the spread64 section is commented out > (and in src/midiobject.cpp where ComputeValue() is called, it's result > is not actually used, so in fact none of the midi options could work). > Presumably this was accidental? I've fixed it locally but it doesn't > behave quite like it used to. Does anyone know what happened? > > I *think* that r2543 did it, but I'm not sure because I'm not too > familiar with digging around svns. The log for that says: > > ------------------------------------------------------------------------ > r2543 | rryan | 2009-01-31 23:35:44 -0500 (Sat, 31 Jan 2009) | 4 lines > > Merging Features_MIDIScriptAutoReactions (2488:HEAD) into trunk. > >
I was probably the one who broke this. Spread64 and some of these other XML modifier tags were massive hacks, and I think I knew I broke Spread64 so I commented it out. I thought the Xponent was the only controller that used Spread64, so I was OK with breaking Xponent support temporarily (or in the worst case, regressing on it for 1.6.2, and leaving that as a known issue). I mentioned this in the Skype meeting a few weeks ago, but I forgot to put it in the minutes. Basically, most of the Xponent support stuff was massive ugly hacks to the MIDI code which I removed while I was cleaning everything up. Spread64 was just one of several things that was going to be broken for that controller. Rather than "fixing" Spread64 now, you should write a script function which does the hackery for you instead. The medium term goal is to eliminate all these weird transformation options and replace those with script functions, so Spread64 is a good one to start with. Thanks, Albert ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Mixxx-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mixxx-devel
