On Fri, Sep 25, 2009 at 8:41 AM, gdkarpman <[email protected]> wrote: > Hey Albert, > There are no required changes to the Standard.kbd.cfg file.
I think I've miscommunicated what I meant by "required". Your patch is to fix CDJ style cueing with the keyboard, but it doesn't fix anything without a patched Standard.kbd.cfg. To me, that's a "required" file. :) > However, if > there are keys for which auto-repeat should be disabled, a third token must > be inserted in that keys line in the keyboard file (see attached; including > both my normal settings and a modded version of the default.) any > non-trivial third token will, at this point, disable auto-repeat, although I > have used ``false'' in all cases for visual consistency. > Without skin or key mapping changes, the only difference is that secondary > function of multi-state pushbuttons is now toggle. The effect is consistent > with what the code thought it was doing as far as state-out handling was > concerned, so that I don't believe it should require any change in skin > files (hasn't produced observed issues with any of the skins included in the > standard build.) I think I understand now, thanks for the clarification. One problem with your patch is that it modifies many of our key bindings, which is something that you didn't mention. For example, you changed the play key for channel 1 from "d" to "x". If you'd like to propose a different set of keys, please do that in a separate patch. I'd like to include your fix in 1.7.1 but we don't want to change the keyboard mapping in our 1.7 series because we'd have to update a slew of documentation and it'd likely confuse a lot of our users. Thanks, Albert > On Fri, Sep 25, 2009 at 12:13 AM, Albert Santoni <[email protected]> wrote: >> >> Hi gdkar, >> >> Were there changes to Standard.kbd.cfg that were supposed to be >> included in this patch? >> >> Also, I'm having a hard time in general understanding whether any of >> your patches will break any existing skins or keyboard mappings. Will >> they? >> >> Thanks, >> Albert >> >> On Fri, Aug 14, 2009 at 1:45 PM, gdkarpman <[email protected]> wrote: >> > CDJ style cue fails for keyboard usage under default setting even with >> > toggle buttons fixed, because autorepeat causes weird stuttering >> > playback. >> > This adds a flag in ConfigValueKbd and code to load from >> > Standard.kbd.cfg to >> > say whether a given key is to autorepeat; also passes key values into >> > keyboard without whitespace (although keys with whitespace aren't usable >> > regardless, so that's minor.) a third item on a key line in >> > Standard.kbd.cfg >> > will now set that key to not autorepeat. >> > Sincerely, >> > --gdkar >> > >> > ------------------------------------------------------------------------------ >> > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 >> > 30-Day >> > trial. Simplify your report design, integration and deployment - and >> > focus >> > on >> > what you do best, core application coding. Discover what's new with >> > Crystal Reports now. http://p.sf.net/sfu/bobj-july >> > _______________________________________________ >> > Mixxx-devel mailing list >> > [email protected] >> > https://lists.sourceforge.net/lists/listinfo/mixxx-devel >> > >> > > > ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Mixxx-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mixxx-devel
