Good catch, Tobias! Not only is it hardcoded for English, but it's 
hardcoded for Windows XP.

In Windows Vista/7, My Music is its own folder in the user's home 
directory named 'Music', not a subfolder of My Documents.

I'd prefer the registry based approach -- popping up some file chooser 
dialog is annoying if we could just figure it out automatically.

-RJ

Tobias Rafreider wrote:
> The hard-coded  iTunes XML path on Windows assumes an English version of 
> Windows, see example below:
>
> #define MIXXX_ITUNES_DB_LOCATION QDir::homePath() + "My Documents/My 
> Music/iTunes/iTunes\ Music\ Library.xml"
> #define MIXXX_ITUNES_DB_LOCATION QDir::homePath() + "Eigene Dokumente/Eigene 
> Music/iTunes/iTunes\ Music\ Library.xml"
> To my mind we have two solutions:
> * Let the user select the path at first run 
> * Read the value "My Music" in 
> "HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\User 
> Shell Folders" to obtain the path of the music folder. This should be 
> independent from the OS language
>
>
> Tobias
>   
> ------------------------------------------------------------------------
>
> ------------------------------------------------------------------------------
> This SF.Net email is sponsored by the Verizon Developer Community
> Take advantage of Verizon's best-in-class app development support
> A streamlined, 14 day to market process makes app distribution fast and easy
> Join now and get one step closer to millions of Verizon customers
> http://p.sf.net/sfu/verizon-dev2dev 
> ------------------------------------------------------------------------
>
> _______________________________________________
> Mixxx-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>   


------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
Mixxx-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Reply via email to