Thanks a lot Tobias, Could you provide your changes as a Bazaar merge directive? You can do this with the 'bzr send' command. First of all, commit your changes locally to your copy of the code, then type:
bzr send -o itunes.md And then send 'itunes.md' to the list. That way your name and commit message will show up in the change log. It makes it easier on us to keep track of contributions :). Thanks, RJ Tobias Rafreider wrote: > It is time for me to dive into Mixxx's source code. Here's my very first > constribution making it possible to detect the iTunesXML file on Windows , > see attached archieve: > > > ChangeLOG: > * I wrote wrote a static method 'getiTunesMusicPath()' for class > ITunesTrackModel > * On Windows the imported playlists within the ITunesFeature have all > locations statrting with "/C:/....." > * Therefore, I modified 'parseTrackNode' in ITunesTrackModel > > > Result: ItunesFeature works (sometimes) on Windows. However, it is often not > possible to expand the list item "iTunes" for some reason (Maybe threading > problems???). To expand on this, context menus are somehow transparent on my > system, see attached screenshot. After pressing "ctrl" it shows up correctly, > i.e non-transparent. > > Tobias > ----- original Nachricht -------- > > Betreff: Re: [Mixxx-devel] iTunes XML path on Windows - Revision 2323 > Gesendet: Mi, 23. Dez 2009 > Von: Russell Ryan<[email protected]> > > >> Good catch, Tobias! Not only is it hardcoded for English, but it's >> hardcoded for Windows XP. >> >> In Windows Vista/7, My Music is its own folder in the user's home >> directory named 'Music', not a subfolder of My Documents. >> >> I'd prefer the registry based approach -- popping up some file chooser >> dialog is annoying if we could just figure it out automatically. >> >> -RJ >> >> Tobias Rafreider wrote: >> >>> The hard-coded iTunes XML path on Windows assumes an English version of >>> >> Windows, see example below: >> >>> #define MIXXX_ITUNES_DB_LOCATION QDir::homePath() + "My Documents/My >>> >> Music/iTunes/iTunes\ Music\ Library.xml" >> >>> #define MIXXX_ITUNES_DB_LOCATION QDir::homePath() + "Eigene >>> >> Dokumente/Eigene Music/iTunes/iTunes\ Music\ Library.xml" >> >>> To my mind we have two solutions: >>> * Let the user select the path at first run >>> * Read the value "My Music" in >>> >> "HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\User >> Shell Folders" to obtain the path of the music folder. This should be >> independent from the OS language >> >>> Tobias >>> >>> ------------------------------------------------------------------------ >>> >>> >>> >> ---------------------------------------------------------------------------- >> -- >> >>> This SF.Net email is sponsored by the Verizon Developer Community >>> Take advantage of Verizon's best-in-class app development support >>> A streamlined, 14 day to market process makes app distribution fast and >>> >> easy >> >>> Join now and get one step closer to millions of Verizon customers >>> http://p.sf.net/sfu/verizon-dev2dev >>> ------------------------------------------------------------------------ >>> >>> _______________________________________________ >>> Mixxx-devel mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel >>> >>> >> > > --- original Nachricht Ende ---- > > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------------ > This SF.Net email is sponsored by the Verizon Developer Community > Take advantage of Verizon's best-in-class app development support > A streamlined, 14 day to market process makes app distribution fast and easy > Join now and get one step closer to millions of Verizon customers > http://p.sf.net/sfu/verizon-dev2dev > ------------------------------------------------------------------------ > > _______________________________________________ > Mixxx-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/mixxx-devel ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ Mixxx-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mixxx-devel
