On Thu, Sep 9, 2010 at 4:10 AM, Sean M. Pappalardo - D.J. Pegasus <[email protected]> wrote: > Hey guys. > > RJ's change to a singleton 30fps timer for the GUI in r2527 of the 1.8 > branch is a great design move. > > I did find two problems as a result that now need fixing: > - The main waveform apparently generates one chunk per timer tick, so it > takes ALOT longer for the main waveform to render. This needs to be spun > off to a separate worker thread so it can run at maximum speed. (Extra > points for calculating the summary waveform in parallel.)
Check out analyserwaveform.cpp and analyserwaveformsummary.cpp. We've always been downsampling the audio in the analyser thread. Something else might be a bit wonky - I think we're painting the lines for the waveform on the timer, and that could be why it's slow. The tiling pixmap renderer does this off-screen so I assume it'd be faster. [disclaimer: I don't have the waveform code in front of me right now, so take all of this with a grain of salt.] > - 30fps is not as smooth as before the change using 1ms latency. > Changing it to 40fps looks much better, so I recommend that be the default. > Thanks, Albert ------------------------------------------------------------------------------ This SF.net Dev2Dev email is sponsored by: Show off your parallel programming skills. Enter the Intel(R) Threading Challenge 2010. http://p.sf.net/sfu/intel-thread-sfd _______________________________________________ Mixxx-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mixxx-devel
