Shouldn't those be deleted in VinylControl::~VinylControl() and not in
VinylControl::ToggleVinylControl?
Otherwise, LGTM. Though the QAction/QMenu's aren't actually leaking since
they are parented to the WTrackTableView they will be deleted when it is
delete but I think it's good to explicitly delete everything.
On Sat, Dec 8, 2012 at 10:17 AM, Owen Williams <owilli...@mixxx.org> wrote:
> I found some objects that were leaking, as well as an issue with the
> order that objects were destroyed. Let me know if this looks ok to
> commit.
>
> Owen
>
>
> ------------------------------------------------------------------------------
> LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
> Remotely access PCs and mobile devices and provide instant support
> Improve your efficiency, and focus on delivering more value-add services
> Discover what IT Professionals Know. Rescue delivers
> http://p.sf.net/sfu/logmein_12329d2d
> _______________________________________________
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
