On Sat, 2012-12-08 at 12:13 -0500, RJ Ryan wrote: > Shouldn't those be deleted in VinylControl::~VinylControl() and not in > VinylControl::ToggleVinylControl?
yes, of course. I cut and pasted them to the wrong place. > > > Otherwise, LGTM. Though the QAction/QMenu's aren't actually leaking > since they are parented to the WTrackTableView they will be deleted > when it is delete but I think it's good to explicitly delete > everything. ok good to know. Owen ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
