>>Please see https://bugs.launchpad.net/mixxx/+bug/1171235 -- my
>>performance improvement to playlist/crate import is bugged, and I
>>submitted a patch for it.
>
>Not the first time broken code has made it in right before a release :).
Granted, but I'm deeply unthrilled to be the cause of such a thing. That's why
I tried to explain the context...it was my threadbare excuse for doing
something so unprofessional. ;-)
>We really could use library unit tests.
I was surprised to find that constraint checking had to be explicitly enabled;
if they had been enforced, it's likely the bugged version of my patch would
have been detected before it left my hands.
>>The source of the bug is an error in the database format [...]
>
>Good catch! Schema versions 1 and 2 never made it into the wild --
>it's from when we were developing the SQLite library in its own branch
>so that explains why we never heard from any users about the conversion
>issue.
Indeed. I was wondering how it managed to be in there!
>>The patch I submitted to bug #1171235 not only fixes my code, it also
>>corrects the constraint in the library table, and adds some comments
>>to the place (i.e. schema 3) where the problem was introduced, and
>>how it could have been avoided.
>
>The REFERENCES change is probably worth doing [...]
Good news. So please check in the change as soon as you can. I don't want my
breakage to go any further!
Steven Boswell
------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
