Hi James,
It's best if we keep the discussion on the bug report. That way others can
find the bug and its related discussion all in one place in the future.
I'll respond to you there,
RJ
On Sat, Apr 27, 2013 at 5:02 PM, James J Fagan <[email protected]>wrote:
> Hi all,
>
> I am still working on fixing the Soundsource API to read float samples but
> I am still stuck on a few things. So far I have sucessfully changed all the
> read methods to deal with CSAMPLE instead of SAMPLE as well as changed all
> the callers so that the code could compile and I know that I must call
> SampleUtil::convert inside each of the soundsources read methods but what I
> don't understand is what exactly I'm checking for to decide if I use or
> don't use SampleUtil::convert. For example in soundSourcemp3.cpp to my
> understanding when an mp3 is dragged into Mixxx the actual file is the
> variable m_file. So when I call read I must check some property of m_file
> to see if it is actually a float or an int mp3 file and then call
> SampleUtil::convert if it is an int. Unfortunately I am not sure what this
> property of m_file is. Also since my read now looks like this:
>
> unsigned SoundSourceMp3::read(unsigned long samples_wanted, const CSAMPLE
> * _destination)
>
> Even if I did know what property to check and the to call
> SampleUtil::convert was needed I still don't know what I would use as the
> const SAMPLE* pSrc for the SampleUtil::convert method because since my read
> takes CSAMPLES now I would need some part of m_file to be of type SAMPLE?
> If anyone can clarify some of this it would be highly appreciated.
>
> Thanks,
> James Fagan
>
>
>
> ------------------------------------------------------------------------------
> Try New Relic Now & We'll Send You this Cool Shirt
> New Relic is the only SaaS-based application performance monitoring service
> that delivers powerful full stack analytics. Optimize and monitor your
> browser, app, & servers with just a few lines of code. Try New Relic
> and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
> _______________________________________________
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
