Hi Nazar,
First of all: fine :-) that the right direction.
Hier my comments:
* I don't like the way you use Lambdas. I think the key benefit is that
they are nameless in the code flow. like this:
mQuery = query;
QFuture<void> f = QtConcurrent::run(
[this] ()
{
// here (in lambda) goes block originally placed
// in concrete dao's query implementation
qDebug() << " # in DAO. Got Query: " << this->mQuery;
// imitate working for a 3 sec
qDebug() << " | working ...";
SleeperThread::msSleep(3000);
} ); Otherwise I am not a friend of using them because the new
syntax will be more confusing then helpfull.
* The critical GUI time is our waveform framerate of about ~ 33.3 ms. So
all Library tasks > ~ 20 ms are producing waveform jerks. * What is the
reason for msSleep? * Is calling processEvents() allowed from a Qt
event? It looks like a recursive call. Deadlock risk! What happens when
a Event triggers a new database action? Kind regards, Daniel
Am 24.04.2013 11:08, schrieb Nazar Gerasymchuk:
> To Mixxx mentors.
>
> I have already created official proposal here --
> https://google-melange.appspot.com/gsoc/proposal/review/google/gsoc2013/troyane/1
> (it is public, everyone can view).
> Please, check it. Any feedback is welcome.
>
> - - -
> Nazar Gerasymchuk
>
>
> ------------------------------------------------------------------------------
> Try New Relic Now & We'll Send You this Cool Shirt
> New Relic is the only SaaS-based application performance monitoring service
> that delivers powerful full stack analytics. Optimize and monitor your
> browser, app, & servers with just a few lines of code. Try New Relic
> and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
>
>
> _______________________________________________
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
