Hey Max,

I actually ripped a bunch of stuff out of the bpm editor and it fixed the 
display issue.  I’m a C++ novice so it’s ugly but feel free to take a look:

https://github.com/leematos/weird-mixxx/blob/6382f10631d731a5d251a1d7ffca6869671a0aec/src/library/bpmeditor.cpp

-Lee

On Oct 1, 2014, at 9:44 AM, Max Linke <max_li...@gmx.de> wrote:

> Hi 
> 
> I wanted to look into these two styling bugs.
> 
> https://bugs.launchpad.net/mixxx/+bug/1296308
> https://bugs.launchpad.net/mixxx/+bug/1201079
> 
> As a start I thought I could look into the new LateNight skin and check out 
> how
> we set the BackGround and ForeGround color there. Ok so lets look at the
> `Library` node in the xml
> 
> ``` /res/skin/LateNight/library.xml
> <Library>
>    <BgColor>#585858</BgColor> <-- gray
>    <FgColor>#fff</FgColor>  <-- something pink
> </Library>
> ```
> 
> The colors that are defined here are never used in the skin. From the looks in
> our skin parser the colors defined here actually are never parsed.
> 
> So where do we usually parse the foreground and background colors for the
> library currently? I also noticed that we don't call 'getLibraryStyle' anymore
> for the new 'Library' node, but somehow the image for preview column is set.
> Where is this done?
> 
> best Max
> 
> ------------------------------------------------------------------------------
> Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
> Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
> Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
> Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
> http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
> _______________________________________________
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
> 
> 
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel

------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Reply via email to