I think it is not required. If you need a review, just issue a normal PR against 1.12 You are able to continue and add commits to this open PR. We do the same for the LibraryConcurentRefactoring branch.
Am 24.07.2015 um 16:23 schrieb Owen Williams: > How about we create a sub-branch of 1.12 and merge your work there, and > then we can have others help out. When it's in good shape we can merge > it back into 1.12. (That way 1.12 stays pristine while we are cleaning > things up.) > > On Fri, 2015-07-24 at 16:11 +0200, S.Brandt wrote: >> Hi, >> Deere maintainer here. >> My current dev branch: [1] >> Fixes (mostly) all bugs for the skin listed: [2] >> It merges cleanly [3], but i`ve submitted no PR yet since it is still >> unfinished, some items on my todo. >> >> >> Unfortunately, time is an major issue. >> >> >> Suggestion? >> Test the skin in its current state and comment and/or submit PR. >> >> >> [1]: https://github.com/esbrandt/mixxx/tree/deere_updates >> [2]: https://blueprints.launchpad.net/mixxx/+spec/1.12-skins >> [3]: >> >> https://github.com/mixxxdj/mixxx/compare/1.12...esbrandt:deere_updates?expand=1 >> ------------ >> S.Brandt >> Mixxx - Free Digital DJ Mixing Software >> www.mixxx.org | Get Involved >> >>> On Jul 23, 2015, at 8:28 PM, Ferran Pujol Camins >>> <ferranpujolcam...@gmail.com> wrote: >>> >>> Hello, I thought I could put some love to Deere. But before I start >>> to commit things that may not be appropriate, I would like to know >>> if there are any specific plans for it. Whose the maintainer? Any >>> suggestions? >> >> ------------------------------------------------------------------------------ >> _______________________________________________ >> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >> http://mixxx.org >> >> >> Mixxx-devel mailing list >> Mixxx-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > > ------------------------------------------------------------------------------ > _______________________________________________ > Get Mixxx, the #1 Free MP3 DJ Mixing software Today > http://mixxx.org > > > Mixxx-devel mailing list > Mixxx-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mixxx-devel ------------------------------------------------------------------------------ _______________________________________________ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
