On Tue, Sep 20, 2016 at 11:42 AM, Daniel Schürmann <dasch...@mixxx.org> wrote: > I have just filed a QT bug > https://bugreports.qt.io/browse/QTBUG-56087 > > > > 2016-09-20 11:17 GMT+02:00 Daniel Schürmann <dasch...@mixxx.org>: >> >> Hi Andreas, >> >> thank you for the patch. >> >> Looking at it, I havenoticed an Qt issue: >> >> In Qt 5, there is >> >> typedef QLatin1String QLatin1Literal; >> >> However, I cannot find the original template constructor: >> >> template<int N> QLatin1Literal(const char(&str)[N]) >> >> So I am afraid this solution here requires char counting until '\0' >> >> >> https://github.com/qt/qtbase/blob/601019e3f42516b5799fe519115f8fbdf44ed18a/src/corelib/tools/qstring.h#L92 >> >> QString has now a template constructor: >> >> https://github.com/qt/qtbase/blob/601019e3f42516b5799fe519115f8fbdf44ed18a/src/corelib/tools/qstring.h#L664 >> >> The sting-builder has the template constructor all the time. >> >> https://github.com/qt/qtbase/blob/601019e3f42516b5799fe519115f8fbdf44ed18a/src/corelib/tools/qstringbuilder.h#L280 >> >> >> Conclusion: >> User Plain char[N] strings in connection with the String builder operator >> % >> >> Would you mind to update the patch or better issue a Github Pull request? >> >> Thank you. >> >> Kind regards, >> >> Daniel >> >> Hello Daniel,
1. sorry for late reply - too many issues 2. thanks for much interesting investigation - really interesting. I expected it would not be that easy :) Before sending the patch I never heard of QStringBuilder. So I checked the qt docs for QString for 4.8 and 5.7 what might have caused the trouble which lead to the patch I sent. 3. I will build/test with plain char[N] strings tomorrow. Do you think that solution will work for Qt 4.8 too? Background: I am (cross) building everything and my images are Qt 4.8 free currently. Testing with Qt 4.8 would cause hours additional build time Cheers Andreas ------------------------------------------------------------------------------ _______________________________________________ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
