On Wed, Aug 20, 2014 at 11:04:02PM +0200, Carlos Dávila wrote:
According to OSM wiki bus stops can be tagged as bus_stop=yes or as
public_transport=platform + bus=yes (or both ways), but current
default style only catches the first case. The same can be said about
tram stops. Attached patch adds rules for the second way of tagging.
Thanks! I think that this can be simplified a little:
( public_transport=platform & (bus=yes | tram=yes) ) |
(highway=bus_stop | railway=tram_stop | railway=halt | railway=station)
I do not think that we need the & (bus=yes | tram=yes) here. These rules
are only setting the name for any kind of stop. They are not yet
creating the POI.
-highway=bus_stop [0x2f17 resolution 24]
+( public_transport=platform & bus=yes ) | highway=bus_stop [0x2f17 resolution
24]
I would just group bus and tram stops together here, but move the rule
after railway=* so that the railway-specific rules would fire first:
@@ -226,7 +226,7 @@
railway=halt [0x2f08 resolution 23]
railway=station [0x2f08 resolution 22]
-railway=tram_stop [0x2f17 resolution 24]
+( public_transport=platform & tram=yes ) | railway=tram_stop [0x2f17
resolution 24]
Here, I would remove your + line and instead write:
public_transform=platform & rail=yes [0x2f08...]
highway=bus_stop|highway=tram_stop|public_transport=platform [0x2f17...]
I did not check if rail=yes is a valid tag.
In this way, if a public_transport=platform is not rail=yes, it will be
assigned the type 0x2f17. All railway stops would be 0x2f08, except tram
stops which are 0x2f17.
Can you submit a revised patch for this?
Marko
_______________________________________________
mkgmap-dev mailing list
[email protected]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
