El 21/08/14 13:40, Marko Mäkelä escribió:
On Wed, Aug 20, 2014 at 11:04:02PM +0200, Carlos Dávila wrote:
According to OSM wiki bus stops can be tagged as bus_stop=yes or as
public_transport=platform + bus=yes (or both ways), but current
default style only catches the first case. The same can be said about
tram stops. Attached patch adds rules for the second way of tagging.
Thanks! I think that this can be simplified a little:
( public_transport=platform & (bus=yes | tram=yes) ) |
(highway=bus_stop | railway=tram_stop | railway=halt | railway=station)
I do not think that we need the & (bus=yes | tram=yes) here. These
rules are only setting the name for any kind of stop. They are not yet
creating the POI.
Done
-highway=bus_stop [0x2f17 resolution 24]
+( public_transport=platform & bus=yes ) | highway=bus_stop [0x2f17
resolution 24]
I would just group bus and tram stops together here, but move the rule
after railway=* so that the railway-specific rules would fire first:
@@ -226,7 +226,7 @@
railway=halt [0x2f08 resolution 23]
railway=station [0x2f08 resolution 22]
-railway=tram_stop [0x2f17 resolution 24]
+( public_transport=platform & tram=yes ) | railway=tram_stop [0x2f17
resolution 24]
Here, I would remove your + line and instead write:
public_transform=platform & rail=yes [0x2f08...]
highway=bus_stop|highway=tram_stop|public_transport=platform [0x2f17...]
I did not check if rail=yes is a valid tag.
There are currently more than 600 rail=yes in Europe, so it must be a
valid tag;-)
In this way, if a public_transport=platform is not rail=yes, it will
be assigned the type 0x2f17. All railway stops would be 0x2f08, except
tram stops which are 0x2f17.
Can you submit a revised patch for this?
Attached
Index: resources/styles/default/points
===================================================================
--- resources/styles/default/points (revisión: 3333)
+++ resources/styles/default/points (copia de trabajo)
@@ -42,21 +42,21 @@
internet_access=yes { name 'Internet ${name}' | 'Internet' } [0x2f12 resolution 24 continue]
internet_access=* & internet_access!=no & internet_access!=yes { name 'Internet(${internet_access}) ${name|def:}' } [0x2f12 resolution 24 continue]
-(highway=bus_stop | railway=tram_stop | railway=halt | railway=station)
+(public_transport=platform | highway=bus_stop | railway=tram_stop | railway=halt | railway=station)
& (ref=* | route_ref=*) {
set ref='${ref|def:}(${route_ref})';
}
-(highway=bus_stop | railway=tram_stop | railway=halt | railway=station)
+(public_transport=platform | highway=bus_stop | railway=tram_stop | railway=halt | railway=station)
& lit=yes & (shelter=yes | covered=yes)
{
set ref='${ref|def:}*';
}
-(highway=bus_stop | railway=tram_stop | railway=halt | railway=station)
+(public_transport=platform | highway=bus_stop | railway=tram_stop | railway=halt | railway=station)
& lit!=yes & (shelter=yes | covered=yes)
{
set ref='${ref|def:}+';
}
-(highway=bus_stop | railway=tram_stop | railway=halt | railway=station)
+(public_transport=platform | highway=bus_stop | railway=tram_stop | railway=halt | railway=station)
& (shelter=no | covered=no)
{
set ref='${ref|def:}-';
@@ -190,8 +190,6 @@
healthcare=hospital | amenity=hospital [0x3002 resolution 22]
healthcare=* | amenity=dentist | amenity=doctors [0x3002 resolution 24]
-highway=bus_stop [0x2f17 resolution 24]
-
highway=motorway_junction [0x2100 resolution 24]
highway=services & mkgmap:area2poi!=true [0x210f resolution 24 default_name 'Services']
@@ -224,9 +222,9 @@
natural=rock [0x6614 resolution 24]
natural=volcano [0x2c0c resolution 24]
-railway=halt [0x2f08 resolution 23]
railway=station [0x2f08 resolution 22]
-railway=tram_stop [0x2f17 resolution 24]
+( public_transport=platform & rail=yes ) | railway=halt [0x2f08 resolution 23]
+public_transport=platform | highway=bus_stop | railway=tram_stop [0x2f17 resolution 24]
shop=bakers [0x2e02 resolution 24]
shop=bakery [0x2e02 resolution 24]
_______________________________________________
mkgmap-dev mailing list
[email protected]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
