rcurtin commented on this pull request.
> + for(size_t i = 0; i < N; i++)
+ probabilities(i) = prob(generator);
+
+ // fit results with probabilities and data
+ GammaDistribution gDist;
+ gDist.Train(rdata, probabilities);
+
+ // fit results with only data
+ GammaDistribution gDist2;
+ gDist2.Train(rdata);
+
+ BOOST_REQUIRE_CLOSE(gDist2.Alpha(0), gDist.Alpha(0), 10);
+ BOOST_REQUIRE_CLOSE(gDist2.Beta(0), gDist.Beta(0), 10);
+
+ BOOST_REQUIRE_CLOSE(alphaReal, gDist.Alpha(0), 10);
+ BOOST_REQUIRE_CLOSE(betaReal, gDist.Beta(0), 10);
Ok, I think that we were getting confused because we were talking about
probabilities for different tests. :) I looked through the most recent code,
and I think the tolerances are fine now. When I was saying that the tolerance
should be small like 1e-5, I was only referencing the test with probabilities
all equal to one. Thanks for the updates.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/834
_______________________________________________
mlpack mailing list
[email protected]
http://knife.lugatgt.org/cgi-bin/mailman/listinfo/mlpack
