Things look good to me minus the one comment about `BOOST_REQUIRE_CLOSE`. I'll
probably refactor the tests very slightly after merge to try and use mlpack's
existing RNGs instead of custom ones. You can add your name to
`src/mlpack/core.hpp` and `COPYRIGHT.txt`. Let me know when you think this is
ready to merge and I'll hit the button. Thanks again for taking the time to
sort out the issues here.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/834#issuecomment-269043638
_______________________________________________
mlpack mailing list
[email protected]
http://knife.lugatgt.org/cgi-bin/mailman/listinfo/mlpack
