On Wed, Jul 6, 2011 at 5:03 PM, j-b-m <j-...@users.sourceforge.net> wrote: > Hi. > > Following the discussion about kdenlive bug 2182(*), attached are some basic > fixes for the oldfilm and charcoal filters. > > There are also lots of places where we have: > > mlt_properties_set( MLT_FILTER_PROPERTIES( this ), "noise", "40" ); > > Wouldn't it be better to have those written like: > mlt_properties_set_int( MLT_FILTER_PROPERTIES( this ), "noise", 40 );
Definitely, except set_double is more illustrative :-) I will do a full review over the next few days. > > Regards > jb > > > (*) http://kdenlive.org/mantis/view.php?id=2182 > > ______________________________________________________________________________ > > diff --git a/src/modules/oldfilm/filter_vignette.c > b/src/modules/oldfilm/filter_vignette.c > index 2a51e79..1aa8b53 100644 > --- a/src/modules/oldfilm/filter_vignette.c > +++ b/src/modules/oldfilm/filter_vignette.c > @@ -122,11 +122,11 @@ mlt_filter filter_vignette_init( mlt_profile profile, > mlt_service_type type, con > */ > > this->process = filter_process; > - mlt_properties_set( MLT_FILTER_PROPERTIES( this ), "smooth", > "0.8" ); > - mlt_properties_set( MLT_FILTER_PROPERTIES( this ), "radius", > "0.5" ); > - mlt_properties_set( MLT_FILTER_PROPERTIES( this ), "x", "0.5" > ); > - mlt_properties_set( MLT_FILTER_PROPERTIES( this ), "y", "0.5" > ); > - mlt_properties_set( MLT_FILTER_PROPERTIES( this ), "opacity", > "0.0" ); > + mlt_properties_set_double( MLT_FILTER_PROPERTIES( this ), > "smooth", 0.8 > ); > + mlt_properties_set_double( MLT_FILTER_PROPERTIES( this ), > "radius", 0.5 > ); > + mlt_properties_set_double( MLT_FILTER_PROPERTIES( this ), > "x", 0.5 ); > + mlt_properties_set_double( MLT_FILTER_PROPERTIES( this ), > "y", 0.5 ); > + mlt_properties_set_double( MLT_FILTER_PROPERTIES( this ), > "opacity", 0.0 > ); > > //mlt_properties_set( MLT_FILTER_PROPERTIES( this ), "end", "" > ); > > diff --git a/src/modules/plus/filter_charcoal.c > b/src/modules/plus/filter_charcoal.c > index 703b322..53978c6 100644 > --- a/src/modules/plus/filter_charcoal.c > +++ b/src/modules/plus/filter_charcoal.c > @@ -167,7 +167,7 @@ mlt_filter filter_charcoal_init( mlt_profile profile, > mlt_service_type type, con > this->process = filter_process; > mlt_properties_set( MLT_FILTER_PROPERTIES( this ), > "x_scatter", "1" ); > mlt_properties_set( MLT_FILTER_PROPERTIES( this ), > "y_scatter", "1" ); > - mlt_properties_set( MLT_FILTER_PROPERTIES( this ), "scale", > "1.5" ); > + mlt_properties_set_double( MLT_FILTER_PROPERTIES( this ), > "scale", 1.5 > ); > mlt_properties_set( MLT_FILTER_PROPERTIES( this ), "mix", "0" > ); > } > return this; > > ------------------------------------------------------------------------------ > All of the data generated in your IT infrastructure is seriously valuable. > Why? It contains a definitive record of application performance, security > threats, fraudulent activity, and more. Splunk takes this data and makes > sense of it. IT sense. And common sense. > http://p.sf.net/sfu/splunk-d2d-c2 > _______________________________________________ > Mlt-devel mailing list > Mlt-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mlt-devel > > -- +-DRD-+ ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
