On Wed, Jul 6, 2011 at 6:08 PM, Dan Dennedy <d...@dennedy.org> wrote: > On Wed, Jul 6, 2011 at 5:03 PM, j-b-m <j-...@users.sourceforge.net> wrote: >> Hi. >> >> Following the discussion about kdenlive bug 2182(*), attached are some basic >> fixes for the oldfilm and charcoal filters. >> >> There are also lots of places where we have: >> >> mlt_properties_set( MLT_FILTER_PROPERTIES( this ), "noise", "40" ); >> >> Wouldn't it be better to have those written like: >> mlt_properties_set_int( MLT_FILTER_PROPERTIES( this ), "noise", 40 ); > > Definitely, except set_double is more illustrative :-) > I will do a full review over the next few days. >
A regex search shows you located all of the ones that should use set_double. I am not going to bother with the integer ones. They are harder to find, and there is no major benefit. -- +-DRD-+ ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
