On Sun, Sep 11, 2011 at 3:02 PM, Brian Matherly <[email protected]> wrote:
> Hi Dan,
> I would like to offer a new filter for your consideration. It is called
> "dynamictext". The change is here:
> https://github.com/pez4brian/mlt/commit/beb7046cedc89efc3715878ba490832bbac5570c

Here are some changes I would like.
1) Replace 'this' with 'filter' (preferred) or 'self' (if filter
already used). 'this' messes up my IDE because it is a C++ thing.
Yeah, I know it is used often elsewhere, but I have not got around to
fixing it everywhere!

2) yaml says // is escape, but it is \

3) call get_filter in init and return null if get_filter returns null
for some reason. That function does not depend on any properties being
set after init, so load it right away.

4) in get_filter, use "pango:" instead of "+.txt" to make it more
clear and direct

5) we now prefer not to compare to NULL and instead use if( pointer )
or if ( !pointer)

6) in init, let "text" be supplied by the arg arg if supplied and
default to "#timecode#" otherwise

-- 
+-DRD-+

------------------------------------------------------------------------------
BlackBerry&reg; DevCon Americas, Oct. 18-20, San Francisco, CA
Learn about the latest advances in developing for the 
BlackBerry&reg; mobile platform with sessions, labs & more.
See new tools and technologies. Register for BlackBerry&reg; DevCon today!
http://p.sf.net/sfu/rim-devcon-copy1 
_______________________________________________
Mlt-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mlt-devel

Reply via email to