Dan, > On Sun, Sep 11, 2011 at 3:02 PM, Brian Matherly <[email protected]> > wrote: >> Hi Dan, >> I would like to offer a new filter for your consideration. It is called >> "dynamictext". The change is here: >> > https://github.com/pez4brian/mlt/commit/beb7046cedc89efc3715878ba490832bbac5570c > > Here are some changes I would like. > 1) Replace 'this' with 'filter' (preferred) or 'self' > (if filter > already used). 'this' messes up my IDE because it is a C++ thing.
No problem. > Yeah, I know it is used often elsewhere, but I have not got around to > fixing it everywhere! Sounds like something I could do. I would be willing to put together a patch to remove the use of "this" from all modules if you would like. > 2) yaml says // is escape, but it is \ Doh! > 3) call get_filter in init and return null if get_filter returns null > for some reason. That function does not depend on any properties being > set after init, so load it right away. Great idea. > 4) in get_filter, use "pango:" instead of "+.txt" to make it > more > clear and direct No problem. > 5) we now prefer not to compare to NULL and instead use if( pointer ) > or if ( !pointer) No problem. > 6) in init, let "text" be supplied by the arg arg if supplied and > default to "#timecode#" otherwise I tried this originally. It worked fine in melt. But when run from Kdenlive, it added a path to the text for some reason (as if it were a file name). Maybe Kdenlive assumes all arguments are files. No problem, I'll look into it. Thanks for your feedback. I appreciate that you are willing to entertain this filter. But before I run off and make a bunch of changes, I would like to feel good that I'm providing the best implementation possible for MLT and Kdenlive (and anyone else that uses it). If you think that the "filter_kdenlivetitle" is the way to go, I'd be glad to go implement it (and forget about this filter). If you think that this filter is the right approach, I'll go make your suggested changes right away. Just let me know your preference. Thanks again for your time, ~Brian P.S. how would you feed about changing the name of the filter from "dynamictext" to "title". If we go this route, I would aspire to eventually add all the features and properties of the kino "Titler" filter (which, in my opinion, is the golden standard). ------------------------------------------------------------------------------ BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA Learn about the latest advances in developing for the BlackBerry® mobile platform with sessions, labs & more. See new tools and technologies. Register for BlackBerry® DevCon today! http://p.sf.net/sfu/rim-devcon-copy1 _______________________________________________ Mlt-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mlt-devel
