On Mon, Jan 23, 2012 at 7:58 PM, Brian Matherly <pez4br...@yahoo.com> wrote: > Dan, > > >>> I did come up with some additional error reporting so that if the xml >>> fails to load, at least it doesn't fail silently: >>> >> https://github.com/pez4brian/mlt/commit/5fc4d19e81e658e1236da5b82457cfa8b428a705 >>> Feel free to pull it if you like. >>> >>> For JB's example file, it prints an error like this: >>> XML parse error: PCDATA invalid Char value 11 >>> row: 21 col: 20 >>> XML parse error: PCDATA invalid Char value 11 >>> row: 30 col: 20 >> >> I definitely like the contribution, but it should use >> mlt_log_warning() instead of fprintf(stderr). The other >> fprintf(stderr) you see there are simply because that file was not yet >> updated to use mlt_log. >> >> My policy is that any new code or code changed around a legacy >> approach should adopt the new approach instead of deferring to >> consistency with the older code in a file. (Same goes for other things >> like no longer comparing pointers with NULL.) However, a single commit >> should not include both a logic change and a comprehensive update to >> the new approach. > > Here is the new error message. > https://github.com/pez4brian/mlt/commit/04df8a240c38d8efed5a822f01f8bb074ace5a01
I made my comments on github. -- +-DRD-+ ------------------------------------------------------------------------------ Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d _______________________________________________ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
