2012/2/14 Maksym Veremeyenko <[email protected]>: > Hi, > > data for overlay image converted from RGBA to YUV422 for each frame. > attached patch save converted image of *pixbuf* producer to avoid converting > it to profile format each time it require to produce resulting frame. > > with that patch and previous SSE2 patches it possible to put full hd logo on > video without dropped frame. > > it is draft version with leak on exit but it could answer the question if it > is a right approach for solving problem with image converted to desired > format once per frame instead of once per load/format_change.
The idea is fine but not the patches. The first patch to mlt_frame is rejected because they are not really needed; use mlt_frame_get_alpha_mask and mlt_frame_get_image. API changes including additions are not taken lightly and need strong justification. These two just add confusion. In the pixbuf patch, you should not call the convert_image virtual function directly; use mlt_frame_get_image(). Unfortunately, mlt_frame_set_image lacks a format parameter. I forget why. For now, just set the format property. mlt_frame_get_alpha_mask() should probably have an out param. I will think about breaking API because there are other API changes coming in this release. For now, you will have to use a computed size for the alpha. Lastly, break clone.size apart into clone.image_size and clone.alpha_size for readability. -- +-DRD-+ ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ Mlt-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mlt-devel
