On Thu, Feb 16, 2012 at 9:44 AM, Dan Dennedy <[email protected]> wrote: > 2012/2/16 Maksym Veremeyenko <[email protected]>: >> 16.02.12 18:54, Dan Dennedy написав(ла): >> >>> 2012/2/16 Maksym Veremeyenko<[email protected]>: >>>> >>>> 15.02.12 20:49, Dan Dennedy написав(ла): >>>> >>>>> 2012/2/14 Maksym Veremeyenko<[email protected]>: >>>>>> >>>>>> >>>>>> Hi, >>>>>> >>>>>> data for overlay image converted from RGBA to YUV422 for each frame. >>>>>> attached patch save converted image of *pixbuf* producer to avoid >>>>>> converting >>>>>> it to profile format each time it require to produce resulting frame. >>>>>> >>>>>> with that patch and previous SSE2 patches it possible to put full hd >>>>>> logo >>>>>> on >>>>>> video without dropped frame. >>>>>> >>>>>> it is draft version with leak on exit but it could answer the question >>>>>> if >>>>>> it >>>>>> is a right approach for solving problem with image converted to desired >>>>>> format once per frame instead of once per load/format_change. >>>>> >>>>> >>>>> >>>>> The idea is fine but not the patches. The first patch to mlt_frame is >>>>> rejected because they are not really needed; use >>>>> mlt_frame_get_alpha_mask and mlt_frame_get_image. API changes >>>>> including additions are not taken lightly and need strong >>>>> justification. These two just add confusion. >>>> >>>> >>>> problem is *mlt_frame_get_alpha_mask* function that generate fake alpha >>>> channel for frames without one. I had a plans to propose drop creating >>>> filled alpha plane with it function and just return NULL, but in the same >>> >>> >>> That is a high impact change that requires analyzing every call to the >>> function, and fixing and testing its impact. >> >> if you decide to break API that will be a good chance to implement that >> feature and fix possible regression caused by that improvement... > > but it is a low priority for me, and I do not see the considerable > gain it would provide, but feel free to clarify
I came to a realization: the current behavior is consistent with mlt_frame_get_audio and mlt_frame_get_image, both of which synthesize data when there is none and no operations on the stack. So, I am very reluctant to change this. -- +-DRD-+ ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ Mlt-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mlt-devel
