On Sun, Sep 30, 2012 at 4:52 AM, j-b-m <j-...@users.sourceforge.net> wrote: > On Thursday 27 September 2012 23:32:50 j-b-m wrote: >> On Thursday 27 September 2012 19:54:14 j-b-m wrote: >> > On Wednesday 26 September 2012 19:29:57 Dan Dennedy wrote: >> > > On Tue, Sep 25, 2012 at 4:35 AM, j-b-m <j-...@users.sourceforge.net> >> >> wrote: >> > > > On Monday 24 September 2012 21:35:04 Dan Dennedy wrote: >> > > >> On Mon, Sep 24, 2012 at 9:02 AM, j-b-m <j-...@users.sourceforge.net> >> > >> > wrote: >> > > > Ok, after some more tests, here is a way to reproduce with color >> > > > producer: >> > > > >> > > > Create an 1920x1080 clip: >> > > > >> > > > melt -profile atsc_1080i_50 color:red out=100 -consumer >> > > > avformat:red.mp4 >> > > > >> > > > Try to make a transition with color clip with HDV profile: >> > > > >> > > > melt -profile hdv_1080_50i color:blue out=100 -track red.mp4 >> > > > -transition >> > > > affine geometry="0/0:100%x100%:50%" >> > > > >> > > > You will see that the red.mp4 clip does not take the full screen. The >> > > > bug >> > > > also happens when using avformat producers. >> > > >> > > no, sorry, still unable to reproduce it. Tried with sdl and avformat >> > > consumer. Are you using very recent git? >> > >> > Strange... Yes, I am always using latest git. I can reproduce with my >> > installation that is self compiled, and also using sunab's experimental >> > packages on Ubuntu 12.10 and 11.10. I am currently setting up a Suse >> > virtual machine to test... >> >> I also cannot reproduce the bug in my OpenSuse 12.2 virtual machine! Very >> strange. I will make further tests tomorrow to understand where is the >> difference. > > > Ahhh, I finally found the problem! The bug is triggered by an optimization > flag: -O2 > > When using the build script, we configure MLT with --enable-debug, which > disables optimization flags. However, when manually compiling MLT not in debug > mode, the "-O2" flag is set and triggers the bug on my system (Ubuntu 12.10, > gcc 4.7.2). > > I was also able to reproduce the problem on an OpenSuse 12.2 with gcc 4.7.1. > > Not sure but it looks like with this optimization, the aspect ratios are > sometimes wrongly rounded, giving for example 1,777777 instead of 1,777778.
Thanks for finding this. My main workstation (based on ubuntu 11.10) has gcc 4.6.1, and while I usually use --enable-debug, I did not reproduce it without. However, I am concerned about how your patch changes some of the math, which seems heavy-handed for a rounding error. Does it fix other cases of mismatching sample aspect rates? Do you think I should trust your judgement/testing and apply it? -- +-DRD-+ ------------------------------------------------------------------------------ Got visibility? Most devs has no idea what their production app looks like. Find out how fast your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219671;13503038;y? http://info.appdynamics.com/FreeJavaPerformanceDownload.html _______________________________________________ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
