On Mon, Jun 23, 2014 at 8:30 AM, Maksym Veremeyenko <ve...@m1stereo.tv> wrote: > 22.06.14 21:26, Dan Dennedy написав(ла): > >> On Sun, Jun 22, 2014 at 6:21 AM, Maksym Veremeyenko<ve...@m1stereo.tv> >> wrote: >>> >>> Hi, >>> >>> attached patch reorder mlt frame initialization to avoid additional >>> mlt_frame_close for some cases. >> >> >> What problem does it solve? > > its avoid calling mlt_frame_close if some error condition happens.
OK > >> I do not like changing the message from "no signal" to "frame is >> invalid." > > Blackmagic's API says: > /.../ > bmdFrameHasNoInputSource No input source was detected – frame is invalid > /.../ The message "no signal" is still better. I reject that change. > >> The existing message is more clear. And the message change >> from "video" to "video image" is useless. > > this change was made to avoid similar error message for different kind of > errors happens in this function... OK, that is accepted. > >> Also, from a code style >> perspective, while I do not often complain, I think if the if block >> has braces, then the else clause should as well. > > i can prepare a patch where all *else* code block remains a brackets. Please do. Thanks -- +-DRD-+ ------------------------------------------------------------------------------ HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing & Easy Data Exploration http://p.sf.net/sfu/hpccsystems _______________________________________________ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
