You make a good point. The same result can be achieved by applying the affine transition. Instead of putting the rotation responsibility on the pango producer, why not allow the watermark filter to use the affine transition? From: Dan Dennedy <d...@dennedy.org> To: Brian Matherly <c...@brianmatherly.com>; Maksym Veremeyenko <ve...@m1stereo.tv>; "mlt-devel@lists.sourceforge.net" <mlt-devel@lists.sourceforge.net> Sent: Tuesday, June 2, 2015 11:24 AM Subject: Re: [Mlt-devel] [PATCH] Implement text rotation in pango producer On Tue, Jun 2, 2015 at 5:49 AM Brian Matherly <c...@brianmatherly.com> wrote:
Personally, I would like to see this implemented in the qtext producer also since we try to keep qtext and pango producers in sync. I agree, but I do not like to impose that requirement on a contributor. Rather, I impose that obligation on me (or whoever approves and merges). That is part of the reason why I did not merge this yet - due to priorities and time. Therefore, if the contributor does both it certainly helps.Also, we have other filters that rotate. Yeah, I know, combining these filters is not optimal for efficiency reasons - especially real-time. But, now this filter is doing affine transform. Will it expand to do all transforms? Will it start to integrate graphics? Does it grow into something approaching kidenlivetitle? Where does it end? Where do we say, "no, we just want to keep this code simple for maintenance reasons; use webvfx, image sequence, or video with alpha for more?" Also, I would suggest "angle" or "rotation" instead of "rot_angle". Or "rotate". Also, the YAML should include "unit: degrees" instead of putting that in the description, but that is a little nitpicky. ~BM From: Maksym Veremeyenko <ve...@m1stereo.tv> To: mlt-devel@lists.sourceforge.net Cc: Dan Dennedy <d...@dennedy.org> Sent: Tuesday, June 2, 2015 4:44 AM Subject: Re: [Mlt-devel] [PATCH] Implement text rotation in pango producer 12.05.15 10:53, Maksym Veremeyenko написав(ла): > Hi, > > attached patch implement text rotation in pango producer. > > example of usage: > > melt \ > -v \ > -profile square_pal \ > /tmp/demo.mp4 \ > -consumer sdl \ > -filter watermark:pango \ > producer.force_apect_ratio="@1/1" \ > producer.text="Hi, here!" \ > producer.family="Arial" \ > producer.size="32" \ > producer.weight="700" \ > producer.fgcolour="#FF000000" \ > producer.bgcolour="#48CCCCFF" \ > producer.rot_angle="48" \ > composite.geometry="300/-300:100%x100%:100%" \ > composite.halign="left" \ > composite.valign="bottom" ping? -- ________________________________________ Maksym Veremeyenko ------------------------------------------------------------------------------ _______________________________________________ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
------------------------------------------------------------------------------
_______________________________________________ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel