Hi, This looks like a partial dup of https://bugs.openjdk.java.net/browse/JDK-8076596
The changes look ok, but I am concerned post initialization there may be code paths taken that require the system class loader to be used but instead the boot stream class loader is used instead. Is that a legitimate concern? Paul. On 25 Sep 2015, at 15:37, Michael Haupt <michael.ha...@oracle.com> wrote: > Hi Peter, > > thanks for this changeset. Note I'm not a Reviewer (with a capital R); please > read this review in lower-case. ;-) > > One question about MethodType: would you mind doing something about the > naming of the newly introduced fromDescriptor() method? Its name does not > suggest in any way that it chooses the class loader differently. The name is > subtly different from that of fromDescriptorString(), and the signature is > identical - it's probably really easy to confuse the two when working at the > core libs level. Unfortunately, the only proposal for a name I can make, > fromDescriptorStringBootCL(), is clunky. Maybe that's acceptable for a > low-level method only visible at package level. > >> Am 25.09.2015 um 08:46 schrieb Peter Levart <peter.lev...@gmail.com>: >> I have run the tests in java.lang.invoke and only have a problem with 1 test >> which seems to be related to the test or jtreg itself and happens also >> without my patch applied: >> >> #Test Results (version 2) >> #Tue Sep 22 09:48:38 CEST 2015 >> ... >> #section:script_messages >> ----------messages:(0/0)---------- >> >> >> test result: Error. Parse Exception: `@library' must appear before first >> `@run' > > Yes. The test is also marked as ignored until another issue is fixed, so that > can be ignored. > > Other than the above remark/suggestion, this looks fine. I'll defer to an > upper-case Reviewer, though. > > Best, > > Michael > > -- > > <http://www.oracle.com/> > Dr. Michael Haupt | Principal Member of Technical Staff > Phone: +49 331 200 7277 | Fax: +49 331 200 7561 > Oracle Java Platform Group | LangTools Team | Nashorn > Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany > <http://www.oracle.com/commitment> Oracle is committed to developing > practices and products that help protect the environment >
signature.asc
Description: Message signed with OpenPGP using GPGMail
_______________________________________________ mlvm-dev mailing list mlvm-dev@openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
