Thanks for the comments, Philipp!
[2018-07-19 03:24 +0200] Philipp Takacs <phil...@bureaucracy.de>
> [2018-07-18 23:13] Vasilii Kolobkov <polezaivs...@ko5v.net>
> > +pseq() {
>
> I'm not sure, if we realy nead this funktion, because it's used on
> two places. In the one place it's easy to remove. On the other place
> I would remove the hole test.
Yep, if we are to remove the inc(1) test, i'm all for just having
a hardcoded list.
> > diff --git a/test/runtest b/test/runtest
> > index 9f35ade..37a23ac 100755
> > --- a/test/runtest
> > +++ b/test/runtest
> > @@ -1,13 +1,15 @@
> > #!/bin/sh
> >
> > set -e
> >
> > export MH_TEST_COMMON="$PWD/common.sh"
> >
> > +. ${MH_TEST_COMMON}
> > +
>
> Would be nice if this patch would also remove the source in
> the single tests.
I do like it that way it is for it makes this dependency a bit more
explicit. Let me know if you see no merit in it and i'll dump
sourcing in each test.
> > diff --git a/test/tests/mhsign/test-mhsign b/test/tests/mhsign/test-mhsign
> > index 3c2bb97..4f24b09 100755
> > --- a/test/tests/mhsign/test-mhsign
> > +++ b/test/tests/mhsign/test-mhsign
> > @@ -3,14 +3,21 @@
> > #
> > # Test mhsign (correct alias expansion with -enc)
> > #
> > ######################################################
> >
> > . "$MH_TEST_COMMON"
> >
> > +phostname()
> > +{
> > + case `uname -s` in
> > + OpenBSD) hostname ;;
> > + *) hostname -f ;;
> > + esac
> > +}
>
> oh hostname, markus has summarised[3] this very good. I wouldn't
> change the test, because it does exact the same as mhsing. Maybe
> after fixing mhsign.
I missed the mhsign(1) discussion, but do agree here. Though it'd
have to be `hostname -f 2>/dev/null | uname -n` so no to fill the
output with errors about unrecognized flag.
> > diff --git a/test/tests/mhstore/test-filenames
> > b/test/tests/mhstore/test-filenames
> > index a1d3c3d..4cfedd3 100755
> > --- a/test/tests/mhstore/test-filenames
> > +++ b/test/tests/mhstore/test-filenames
> > @@ -7,15 +7,15 @@
> >
> > . "$MH_TEST_COMMON"
> >
> > require_locale en_US.utf-8 en_US.utf8
> > LC_ALL=en_US.UTF-8
> > export LC_ALL
> >
> > -tempdir=`TMPDIR=$MH_TEST_DIR mktemp -d -t "XXXXX"`
> > +tempdir=`TMPDIR=$MH_TEST_DIR mktemp -d -t "XXXXXX"`
>
> Why not just ``mktemp -d''?
Guess it's because i just patched it without giving it a proper
thought :) Will fix.
> [3] https://www.mail-archive.com/mmh@marmaro.de/msg00559.html
