Comment #10 on issue 152 by [email protected]: Implement
insertSubscriberData MAP message
http://code.google.com/p/jss7/issues/detail?id=152
1. GPRSSubscriptionData - unittest does not looks good for me:
- assertEquals(apnOiReplacement.getData(), this.getAPNOIReplacementData());
- this can not be used for arrays
2. InterCUGRestrictionsTest - use the
constructor "InterCUGRestrictionsImpl(InterCUGRestrictionsValue val)" and a
getter "InterCUGRestrictionsValue getInterCUGRestrictionsValue()" for
testing
Other primitives look good for me.
Thanks for a good work.
To go forward, please:
1. commit himself THIS patch WITHOUT CHANGES into a jss7 master branch
2. make updates for about which I said in my remarks
3. public your next patch for revising
Feel free for asking questions if you have some doubts
