Comment #14 on issue 152 by [email protected]: Implement
insertSubscriberData MAP message
http://code.google.com/p/jss7/issues/detail?id=152
6. EPSQoSSubscribedImpl: for such type sequences (when ALL parameters are
context-specific even if some of them are mandatory) we can not to
use "num" but just use "switch (tag)" for all parameters. Code will be less
complicated. Moreover you do not use "num" for checking if all mandatory
parameters are present. Your current implementatiopn is absolutely fine,
you need not make any update. This is just for info for future.
7. LSAAttributes:
LSAAttributes content is described 3GPP TS 48.008:
Bits 1 to 4 of octet (x+1) define the priority of the LSA identification.
Bit 4321
0000 priority 1 = lowest priority
0001 priority 2 = second lowest priority
: : : :
1111 priority 16= highest priority
If the preferential access indicator (bit 5 of octet (x+1)) is set to 1 the
subscriber has preferential access in the LSA. If
the active mode support indicator (bit 6 of octet (x+1)) is set to 1 the
subscriber has active mode support in the LSA.
Coding of the i-th LSA identification with attributes:
8 7 6 5 4 3 2 1
spare act pref priority
9. LSAIdentity:
11 Identification of Localised Service Area
Cells may be grouped into specific localised service areas. Each localised
service area is identified by a localised
service area identity (LSA ID). No restrictions are placed on what cells
may be grouped into a given localised service
area.
The LSA ID can either be a PLMN significant number or a universal identity.
This shall be known both in the networks
and in the SIM.
The LSA ID consists of 24 bits, numbered from 0 to 23, with bit 0 being the
LSB. Bit 0 indicates whether the LSA is a
PLMN significant number or a universal LSA. If the bit is set to 0 the LSA
is a PLMN significant number; if it is set to
1 it is a universal LSA.
I think the only one getter can be added for LSAIdentity: boolean
isPlmnSignificantLSA() { return !(data[2] & 0x01); }
Do your agree?
10. LSAInformationImpl:
please replace into toString()
sb.append("completeDataListIncluded ");
with
sb.append("completeDataListIncluded, ");
to be continued...
