https://gerrit.wikimedia.org/r/#/c/137930/ is the patch that should make sure that only edits are tagged (liangent's patch was for them not showing up in diffs pages, IIRC?). Needs merge + SWAT.
On Fri, Jun 6, 2014 at 6:26 AM, Dario Taraborelli <[email protected]> wrote: > Thanks, Max. > > There are 201 tagged records for mobile app account creations in > enwiki.change_tag [1] stored prior to the fix and a bunch more in other > wikis. Should we try and purge them or would that be a PITA? I also confirm > that account registrations are being logged via EventLogging > (ServerSideAccountCreation_5487345) with UA starting with > “WikipediaApp/2.0-beta3”. > > Dario > > [1] SELECT * FROM enwiki.change_tag WHERE ct_rev_id IS NULL AND ct_tag = > “mobile app edit”; > [2] SELECT * FROM `ServerSideAccountCreation_5487345` WHERE userAgent LIKE > “WikipediaApp%”; > > On Jun 5, 2014, at 4:53 PM, Max Semenik <[email protected]> wrote: > > Was deployed a few minutes ago. > > > On Thu, Jun 5, 2014 at 4:51 PM, Dario Taraborelli > <[email protected]> wrote: >> >> thanks, guys. >> >> Dan/Yuvi: ping me when it’s done so I can look up the data. >> >> On Jun 5, 2014, at 1:58 PM, Dan Garry <[email protected]> wrote: >> >> Great, thanks! There's still an issue here though, namely that we're >> tagging account creations using the "mobile app edit" tag. We did this so we >> could see the account creations coming in in real time. However, Dario >> informs me that it's inconsistent with out strategy for logging account >> creations, and that since the entries are created with no rev_id that it >> could end up causing the Analytics team a lot of headaches. >> >> I wanted to make sure that if we remove the tagging that we don't lose our >> ability to collect this data. Dario assures me that this data is still >> available in ServerSideAccountCreation so we can still generate statistics >> for how many people are registering. >> >> So we need a patch written to make sure we don't tag account creations >> with our app edit tag. Yuvi said he'd work on this, and try to get it SWAT >> deployed either tomorrow morning or on Monday morning. >> >> Thanks, >> Dan >> >> >> On 5 June 2014 11:33, Brion Vibber <[email protected]> wrote: >>> >>> Change looks good and I've merged it, but if we need to push it in a >>> hurry we'll still need to arrange an LD or SWAT. >>> >>> -- brion >>> >>> >>> On Thu, Jun 5, 2014 at 6:13 AM, Liangent <[email protected]> wrote: >>>> >>>> I think https://gerrit.wikimedia.org/r/#/c/137563/ fixes this. >>>> >>>> -Liangent >>>> >>>> On Thu, Jun 5, 2014 at 11:30 AM, Dario Taraborelli >>>> <[email protected]> wrote: >>>> > This afternoon Dan and I reviewed how tags from the android app are >>>> > captured >>>> > in the change_tag and tag_summary tables. >>>> > >>>> > (1) We noticed that the “mobile app edit” tag is applied to >>>> > recentchanges >>>> > events that are not edits, but new account registrations: >>>> > >>>> > SELECT * FROM enwiki.change_tag WHERE ct_rev_id IS NULL AND ct_tag = >>>> > "mobile >>>> > app edit"; >>>> > >>>> > ct_rc_id ct_log_id ct_rev_id ct_tag ct_params >>>> > 661123291 56899294 NULL mobile app edit NULL >>>> > 661123407 56899301 NULL mobile app edit NULL >>>> > 661124928 56899375 NULL mobile app edit NULL >>>> > 661127933 56899610 NULL mobile app edit NULL >>>> > 661128644 56899685 NULL mobile app edit NULL >>>> > 661131626 56899908 NULL mobile app edit NULL >>>> > 661133278 56899998 NULL mobile app edit NULL >>>> > 661134572 56900072 NULL mobile app edit NULL >>>> > 661140653 56900620 NULL mobile app edit NULL >>>> > 661155198 56901558 NULL mobile app edit NULL >>>> > 661155799 56901593 NULL mobile app edit NULL >>>> > 661156983 56901659 NULL mobile app edit NULL >>>> > >>>> > AFAIK this is unusual behavior for tags and will create artifacts in >>>> > tagged >>>> > revisions unless people are aware that all these registration-related >>>> > events >>>> > always need to be excluded (it’s also confusing because the name of >>>> > the tag >>>> > explicitly refers to an edit). As suggested earlier [1], we should not >>>> > track >>>> > the source of account registrations via MediaWiki tags but via the >>>> > ServerSideAccountCreation log. >>>> > >>>> > (2) edits made on apps should be stored with two separate tags: >>>> > “mobile >>>> > edit” and “mobile app edit”. The tags are correctly stored in the >>>> > change_tag >>>> > table with 2 records for each revisions, e.g. >>>> > >>>> > SELECT * FROM enwiki.change_tag WHERE ct_rc_id = 661110028; >>>> > >>>> > ct_rc_id ct_log_id ct_rev_id ct_tag ct_params >>>> > 661110028 NULL 611585155 mobile app edit NULL >>>> > 661110028 NULL 611585155 mobile edit NULL >>>> > >>>> > but when the tags are combined in the tag_summary table, the “mobile >>>> > app >>>> > edit” tag is lost: >>>> > >>>> > SELECT * FROM enwiki.tag_summary WHERE ts_rc_id = 661110028; >>>> > >>>> > ts_rc_id ts_log_id ts_rev_id ts_tags >>>> > 661110028 NULL 611585155 mobile edit >>>> > >>>> > This should not be the case, the 2 tags should be concatenated in the >>>> > ts_tags field, see for example this desktop revision with 2 tags: >>>> > >>>> > SELECT * FROM enwiki.change_tag WHERE ct_rc_id = 578489188; >>>> > >>>> > ct_rc_id ct_log_id ct_rev_id ct_tag ct_params >>>> > 578489188 NULL 555564321 gettingstarted edit NULL >>>> > 578489188 NULL 555564321 visualeditor NULL >>>> > >>>> > SELECT * FROM enwiki.tag_summary WHERE ts_rc_id = 578489188; >>>> > >>>> > ts_rc_id ts_log_id ts_rev_id ts_tags >>>> > 578489188 NULL 555564321 gettingstarted edit,visualeditor >>>> > >>>> > I believe that neither (1) nor (2) is intended behavior for apps. Can >>>> > you >>>> > guys confirm and if so, can we fix this? >>>> > >>>> > Dario >>>> > >>>> > >>>> > [1] http://lists.wikimedia.org/pipermail/mobile-l/2014-May/007150.html >>>> > >>>> > _______________________________________________ >>>> > Mobile-l mailing list >>>> > [email protected] >>>> > https://lists.wikimedia.org/mailman/listinfo/mobile-l >>>> > >>>> >>>> _______________________________________________ >>>> Mobile-l mailing list >>>> [email protected] >>>> https://lists.wikimedia.org/mailman/listinfo/mobile-l >>> >>> >>> >>> _______________________________________________ >>> Mobile-l mailing list >>> [email protected] >>> https://lists.wikimedia.org/mailman/listinfo/mobile-l >>> >> >> >> >> -- >> Dan Garry >> Associate Product Manager for Platform and Mobile Apps >> Wikimedia Foundation >> >> >> >> _______________________________________________ >> Mobile-l mailing list >> [email protected] >> https://lists.wikimedia.org/mailman/listinfo/mobile-l >> > > > > -- > Best regards, > Max Semenik ([[User:MaxSem]]) > > > > _______________________________________________ > Mobile-l mailing list > [email protected] > https://lists.wikimedia.org/mailman/listinfo/mobile-l > -- Yuvi Panda T http://yuvi.in/blog _______________________________________________ Mobile-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mobile-l
