[mochikit] Re: [Fwd: pulsate patch]

[Bob Ippolito]

On Jun 18, 2006, at 2:12 PM, whit wrote: From: whit <[EMAIL PROTECTED]> Date: June 18, 2006 1:35:41 PM PDT Subject: pulsate patch poking around on trunk. patch fixes missing 'this'. -w Index: Visual.js =================================================================== --- Visual.js (revision 1027) +++ Visual.js (working copy) @@ -1630,7 +1630,7 @@          duration: 3.0,          from: 0,          afterFinishInternal: function (effect) { -            d.setStyle(effect.element, {opacity: oldOpacity}); +            d.setStyle(effect.element, {opacity: this.oldOpacity});          }      }, options || {});      var oldOpacity = d.getInlineOpacity(element); That patch is incorrect, it doesn't fix anything. oldOpacity is in the closure, not on "this" (and even if it was on "this", it would still be wrong because it's in a different function). -bob --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "MochiKit" group. To post to this group, send email to mochikit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/mochikit -~----------~----~----~----~------~----~------~--~---